Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] supply DQM for SiPixelCalSingleMuonTight #39386

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 13, 2022

backport of #39382

PR description:

With the foreseen increase of isolated muon trigger rates (see https://its.cern.ch/jira/browse/CMSHLT-2465 ) it becomes possible to run the SiPixelCalSingleMuonTight at express, allowing for quasi-online efficiency monitoring.
This PR adds a stub of DQM monitor for that AlCa flavour to start producing basic cluster properties histograms that are used as ingredients of the hit efficiency measurement.

PR validation:

Run

 runTheMatrix.py -l 1002.4 -t 4 -j 8 --iboes

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #39382, needed for data-taking monitoring purposes.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

type trk, new-feature

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQMOffline/CalibTracker (dqm)
  • DQMOffline/Configuration (dqm)

@perrotta, @rappoccio, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @davidlange6, @micsucmed, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @mmusich, @threus, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

test parameters:

  • workflow = 1002.4

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

please test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 13, 2022

urgent

  • would be good to have for data-taking when collisions resume.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbb9eb/27509/summary.html
COMMIT: 157c785
CMSSW: CMSSW_12_4_X_2022-09-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39386/27509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dbb9eb/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3779336
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3779292
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.93 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 2.455 KiB AlCaReco/SiPixelCalSingleMuonTight
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 211 log files, 45 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 2 / 50 workflows

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

Pull request #39386 was updated. @perrotta, @rappoccio, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @davidlange6, @micsucmed, @fabiocos, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 15, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbb9eb/27554/summary.html
COMMIT: cbf0127
CMSSW: CMSSW_12_4_X_2022-09-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39386/27554/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dbb9eb/1002.4_RunDoubleMuon2022B+RunDoubleMuon2022B+TIER0PROMPTRUN3+HARVESTPROMPTRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3779336
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3779304
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.926 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1002.4,... ): 2.455 KiB AlCaReco/SiPixelCalSingleMuonTight
  • DQMHistoSizes: changed ( 1002.4,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1002.4,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 211 log files, 45 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 2 / 50 workflows

@francescobrivio
Copy link
Contributor

@cms-sw/dqm-l2 has this been tested in P5?
Although, as far as I understood, this should only affect offline dqm to allow extra monitoring at Express-level.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 15, 2022

has this been tested in P5?

testing in the online DQM serves no purpose at all as this is run only in the offline DQM.

@rovere
Copy link
Contributor

rovere commented Sep 15, 2022

Could @cms-sw/dqm-l2 please review and sign again this PR?

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit fbd848b into cms-sw:CMSSW_12_4_X Sep 17, 2022
@mmusich mmusich deleted the SiPixelCalSingleMuonTightDQM_12_4_X branch September 17, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants