Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing, Laser and Hot cell quality plots adjustments [12_5_X] #39327

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Sep 7, 2022

PR description:

This PR does the following in ECAL DQM plots:

  1. Changes the threshold in Timing quality summary to reduce the false positives in Ecal Endcaps
  2. Changes the amplitude threshold in laser quality for the forward region of Ecal Endcaps
  3. Disables the condition for setting entire FED to RED in Hot Cell quality as it's creating false alarms in the presence of single hot towers.

PR validation:

Validated by running the standard online Ecal DQM configuration and checking the output on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of master PR: #39161. Backport is done to have the changes available in 12_5_X which will be used next in production.
Backport to 12_4_X: #39162

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_5_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

please test

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

backport of #39161

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df3fa4/27394/summary.html
COMMIT: 722b705
CMSSW: CMSSW_12_5_X_2022-09-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39327/27394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695616
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • differences in Ecal Endcap Timing DQM plots as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2022

+1

@cmsbuild cmsbuild merged commit 1d9fcab into cms-sw:CMSSW_12_5_X Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants