-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS NANOAOD dependency hotfix #39294
PPS NANOAOD dependency hotfix #39294
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39294/31974
|
A new Pull Request was created by @grzanka (Leszek Grzanka) for master. It involves the following packages:
@cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Co-authored-by: Laurent Forthomme <lforthomme@protonmail.com>
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39294/31979
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99f538/27328/summary.html Comparison SummarySummary:
|
integration test running https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/pipelines/4459639 |
It does not seem like the tau module failure ( |
please bear with me. |
@vlimant what is the status of the integration testing ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@@ -58,7 +50,7 @@ | |||
), | |||
) | |||
|
|||
protonTablesTask = cms.Task(filteredProtons,protonTable,multiRPTable) | |||
protonTablesTask = cms.Task(protonTable,multiRPTable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Checking): shouldn't ctppsProtons
be added to the task in place ot filteredProtons
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Checking): shouldn't
ctppsProtons
be added to the task in place otfilteredProtons
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 |
PR description:
This PR resolves an issue reported by @mariadalfonso in #39197 (comment)
Production of proton tables in PPS NANOAOD builders used a filtering method (set of Proton POG quality checks) which was implemented as an EDProducer located in
RecoCTPPS/ProtonReconstruction/plugins/PPSFilteredProtonProducer.cc
.With that modification this filtering is disabled, removing dependencies on
RecoCTPPS/ProtonReconstruction
, instead proton data is directly taken from MINIAOD collection.We foresee adding in the future another modification which enables to use of such filtering in an on-demand scenario and with proper dependencies.
PR validation:
The limited battery of tests shows no errors (
runTheMatrix
).Impact on the NANOAOD production was cross-checked by the proton POG group (@diemort )
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport.