Enable veto logic for HG PCL Tracker alignment

[dmeuser]

PR description:

In this PR the veto logic for the HG PCL Tracker alignment is enabled. The same veto logic as used for the old LG PCL alignment is employed, which vetoes the update of the alignment as soon as the movement or the uncertainty an a movement for a alignable exceeds a given thresholds. The thresholds are defined in payloads, which were modified for the HG PCL alingment in #38195.

PR validation:

The PR can be tested using runTheMatrix.py -l 1001.2

@mmusich, @connorpa, @antoniovagnerini, @consuegs

[mmusich]

type trk, new-feature

[mmusich]

test parameters:

• workflow = 1001.2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39189/31796

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dmeuser for master.

It involves the following packages:

• Alignment/MillePedeAlignmentAlgorithm (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-416f8a/27089/summary.html
COMMIT: 7466843
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39189/27089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-416f8a/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA+ALCAHARVD4+ALCAHARVDSIPIXELALIHG

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3693145
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693121
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 219 log files, 49 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• Changes only in MTD
• 1001.2 test passes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

Changes only in MTD

I was wondering, since this seems to be a persistent feature in the PR comparisons, if there is already a cmssw gitHub issue to track it down.

[perrotta]

+1

[tvami]

Changes only in MTD

I was wondering, since this seems to be a persistent feature in the PR comparisons, if there is already a cmssw gitHub issue to track it down.

I spoke to Phat (@cms-sw/upgrade-l2 ) about it recently, he promised to have a look at it. Not sure where we are now. To my knowledge there is no issue about it, but Phat should confirm

[srimanob]

Not done yet, sorry. Will follow up with MTD next week, if the issue is understood, or need more investigation.

[tvami]

Not done yet, sorry. Will follow up with MTD next week, if the issue is understood, or need more investigation.

Maybe you could create a github issue about it then? Thanks!

[mmusich]

Maybe you could create a github issue about it then? Thanks!

yes, please.

[srimanob]

Here it is,
#39214
(I thought we had it already, or just a comment in one of merged PR and private chat, not sure)