Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tag for PPS PCL, move SiStrips tags to Prod in DropBoxMetadata #39181

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Aug 24, 2022

PR description:

As requested in https://cms-talk.web.cern.ch/t/new-tag-for-pcl-for-pps-timingcalibration/14245 we moved the PPS Timing PCL tag to v1

I took the opp to fix some other metadatas for the strips (in agreement with the strips convenors)

PR validation:

The produced payload differs only in the keys where it should:
https://cern.ch/go/z8gx

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not really needed, but I think we should have it in 12_4_X, that's where it's really used

@tvami
Copy link
Contributor Author

tvami commented Aug 24, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39181/31774

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • CondFormats/Common (db, alca)

@malbouis, @yuanchao, @saumyaphor4252, @ggovi, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c668/27062/summary.html
COMMIT: 1c5856a
CMSSW: CMSSW_12_5_X_2022-08-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39181/27062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3693084
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3693054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Aug 24, 2022

+1

  • the PR doesnt really do anything in itself, it's really mostly documentation

@tvami tvami changed the title Add new tag for PPS PCL, move SiStrips tags to Prod Add new tag for PPS PCL, move SiStrips tags to Prod in DropBoxMetadata Aug 24, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 22a8608 into cms-sw:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants