[124X] Fix PPS timing detectors record and tag names for PCL, fix further bugs for SAMPIC wf

[tvami]

PR description:

See #38981 and #38893

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38981 and #38893

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)
• CondFormats/Common (db, alca)
• CondFormats/PPSObjects (alca)
• Configuration/StandardSequences (operations)

@perrotta, @malbouis, @rappoccio, @yuanchao, @tvami, @cmsbuild, @saumyaphor4252, @ggovi, @qliphy, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @grzanka, @lecriste, @mmusich, @slomeo, @mtosi, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add run3 PPS TDC and SAMPIC relvals #38893

[tvami]

type ctpps,bugfix

[tvami]

urgent

• needed for data taking

[tvami]

backport of #38981

[tvami]

backport of #38893

[tvami]

@cmsbuild , please test

[tvami]

@cmsbuild , please abort

[cmsbuild]

Pull request #38982 was updated. @perrotta, @malbouis, @rappoccio, @yuanchao, @tvami, @cmsbuild, @saumyaphor4252, @ggovi, @qliphy, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

Pull request #38982 was updated. @perrotta, @malbouis, @rappoccio, @yuanchao, @tvami, @saumyaphor4252, @ggovi, @qliphy, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please check and sign again.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e0d9b/26673/summary.html
COMMIT: 2b442ca
CMSSW: CMSSW_12_4_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38982/26673/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677212
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

• the error is unrelated

[ChrisMisan]

@tvami can you explain why the tag was changed to PPSDiamondSampicCalibration_pcl?

[tvami]

@tvami can you explain why the tag was changed to PPSDiamondSampicCalibration_pcl?

To be in line with all the stuff above, both the HPTDC and the alignment have this structure if you look just above a few lines

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e0d9b/26679/summary.html
COMMIT: 2b442ca
CMSSW: CMSSW_12_4_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38982/26679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677218
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[malbouis]

+1

[tvami]

@cms-sw/orp-l2 we are essentially fully signed

[tvami]

@cms-sw/orp-l2 it seems the IB with the master version of this PR is running fine

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.