HLTrigger/Timer: add function FastTimerService::fix_for_dqm which replaces check for illegal dqm characters for path so it can be used on paths and labels.

[gartung]

HLTrigger/Timer: add function FastTimerService::fix_for_dqm which replaces check for illegal dqm characters for path so it can be used on paths and labels.

Fixes this error seen when running FastTimerService on a standalone process

03-Aug-2022 15:52:42 CEST  Initiating request to open file /data/cmsbld/jenkins/workspace/ib-run-profiling/file:step2.root
03-Aug-2022 15:52:48 CEST  Successfully opened file /data/cmsbld/jenkins/workspace/ib-run-profiling/file:step2.root
2022-08-03 15:52:59.070874: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  SSE4.1 SSE4.2 AVX AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
----- Begin Fatal Exception 03-Aug-2022 15:53:07 CEST-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
 Monitor element path name: 'merService/process RECO modules/ecalDigis@cpu time_thread' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
   Additional Info:
      [a] Another exception was caught while trying to clean up files after the primary fatal exception.
----- End Fatal Exception -------------------------------------------------
03-Aug-2022 15:53:07 CEST  Closed file /data/cmsbld/jenkins/workspace/ib-run-profiling/file:step2.root

The error was caused by the ecalDigis@cpu label. The @ character is used in SwitchProducer labels.

Validated locally using profiling scripts.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38963/31411

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38963/31411/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38963/31411/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38963/31412

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

• HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[gartung]

enable profiling

[gartung]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d69cf0/26629/summary.html
COMMIT: 954a95d
CMSSW: CMSSW_12_5_X_2022-08-03-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38963/26629/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691510
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691480
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[gartung]

@fwyzard The change is here.

[fwyzard]

thanks, I guess I missed it !

[gartung]

I force pushed the formatting update. Sometimes github does not register force pushed changes.

[fwyzard]

however the signature and merge was a bit too eager :-(

[fwyzard]

please see #38966

[missirol]

however the signature and merge was a bit too eager :-(

Sorry. Thanks for the PR, Andrea.