Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the autoSkim.py for new HLT menu v1.3 #38909

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

sam7k9621
Copy link
Contributor

@sam7k9621 sam7k9621 commented Aug 1, 2022

PR description:

To be synced with PD changes in the new HLT menu (v1.3)

  1. Merged SingleMuon and DoubleMuon into Muon dataset
  2. Merged JetHT and MET into JetMET dataset
  3. Removed unused PD ParkingBPH

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38933

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

A new Pull Request was created by @sam7k9621 for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bbilin
Copy link
Contributor

bbilin commented Aug 1, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebb978/26562/summary.html
COMMIT: 680fc37
CMSSW: CMSSW_12_4_X_2022-08-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38909/26562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 2, 2022

@sam7k9621 Is there a corresponding PR in master?

@sam7k9621
Copy link
Contributor Author

@sam7k9621 Is there a corresponding PR in master?

@qliphy I just created a PR in master and updated the backport info.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

Pull request #38909 was updated. @cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please check and sign again.

@kskovpen
Copy link
Contributor

kskovpen commented Aug 4, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebb978/26646/summary.html
COMMIT: 85b647c
CMSSW: CMSSW_12_4_X_2022-08-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38909/26646/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

kskovpen commented Aug 5, 2022

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 8, 2022

+1

@cmsbuild cmsbuild merged commit 67e38f2 into cms-sw:CMSSW_12_4_X Aug 8, 2022
@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

@sam7k9621 It seems this backport PR brought some unit test issue in 12_4_X IB which doesn't appear in the master IB:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc10/CMSSW_12_4_X_2022-08-09-1100/unitTestLogs/Configuration/DataProcessing#/902-902

Exception: Impossible to map SingleMuon from {'BTagMu': 'LogError+LogErrorMonitor', 'DisplacedJet': 'EXODisplacedJet+EXODelayedJet+EXODTCluster+EXOCSCCluster+LogError+LogErrorMonitor', 'JetMET': 'JetHTJetPlusHOFilter+EXOHighMET+EXODelayedJetMET+LogError+LogErrorMonitor', 'EGamma': 'ZElectron+WElectron+EXOMONOPOLE+LogError+LogErrorMonitor', 'Tau': 'LogError+LogErrorMonitor', 'Muon': 'ZMu+LogError+LogErrorMonitor', 'MuonEG': 'TopMuEG+LogError+LogErrorMonitor', 'NoBPTX': 'EXONoBPTXSkim+LogError+LogErrorMonitor', 'HcalNZS': 'LogError+LogErrorMonitor', 'HLTPhysics': 'LogError+LogErrorMonitor', 'ZeroBias': 'LogError+LogErrorMonitor', 'Commissioning': 'EcalActivity+LogError+LogErrorMonitor', 'Cosmics': 'CosmicSP+CosmicTP+LogError+LogErrorMonitor', 'MonteCarlo': 'EXODisappTrk+LogError+LogErrorMonitor'}

Failure for configuration: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_4_X_2022-08-09-1100/src/Configuration/DataProcessing/test/RunPromptReco.py --scenario ppEra_Run2_2018 --reco --aod --dqmio --global-tag GLOBALTAG --lfn=/store/whatever --alcareco TkAlMinBias+SiStripCalMinBias --PhysicsSkim=@SingleMuon: status 1
status = 256

---> test TestConfigDP had ERRORS
TestTime:1210
^^^^ End Test TestConfigDP ^^^^

Tests for package Configuration/DataProcessing ran.

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

@sam7k9621 Is there anything missing to backport?

@sam7k9621
Copy link
Contributor Author

@qliphy thank you for the reminder, I have applied a new PR to fix this issue #39009

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

Thanks @sam7k9621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants