Fix VtxSmearing parameters for 2022 Run 3 MC

[francescobrivio]

PR description:

As reported in this CMSTalk post the position of the BPIX barycenter reported in this Twiki was previously wrong for 2021 and 2022, while it has now been fixed starting from rev=45 of the twiki.
In CMSSW the BPIX barycenter directly affects the vertex smearing positions which are computed as:

BeamSpot position - BPIX barycenter

This PR updates the VtxSmearing parameters of the Realistic25ns13p6TeVEarly2022CollisionVtxSmearingParameters scenario tu use to correct BPIX barycenter for 2022.

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but a 12_4_X backport will be opened soon.

FYI @cms-sw/tracking-pog-l2 @cms-sw/trk-dpg-l2 @cms-sw/alca-l2 @cms-sw/pdmv-l2 @rappoccio @dzuolo

[francescobrivio]

type bug-fix

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38825/31199

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• IOMC/EventVertexGenerators (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5c57f/26389/summary.html
COMMIT: 5ec14bf
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38825/26389/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5c57f/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e5c57f/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3706484
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3706448
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[francescobrivio]

hold

• PR is ok, but we should discuss at the ORP what to do

[cmsbuild]

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[perrotta]

hold

• PR is ok, but we should discuss at the ORP what to do

@francescobrivio could you please anticipate what has to be discussed at the ORP next Tuesday, so that we can get there prepared? According to what was presented yesterday by PPD (see page 8 in https://indico.cern.ch/event/1184335/contributions/4975916/attachments/2483642/4264021/22-07-21_News_PPD.pdf) once Tracker DPG (@mmusich ...) agrees with the numbers put in the fix we should merge it, because the MinBias productions in 12_4_X have to be restarted with those fixed parameters. What else should be discussed at the ORP?

[mmusich]

but we should discuss at the ORP what to do

Sorry, what's there to discuss?

[mmusich]

once Tracker DPG (@mmusich ...) agrees with the numbers put in the fix we should merge it, because the MinBias productions in 12_4_X have to be restarted with those fixed parameters. What else should be discussed at the ORP?

I agree, the numbers seems to be correct as per actual TK DPGs @connorpa and @tsusa message, so why is this held?

[francescobrivio]

@perrotta @mmusich you are right, I must have misunderstood a discussion I had yesterday with @rappoccio, but indeed this should be merged. I'll unhold.

[francescobrivio]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1