Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] #38816

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_4_X.

This version of the GRun HLT menu corresponds to HLT V1.3 for 2022 pp data-taking.

This is the PR for the master branch, which will then be backported to 12_4_X (the latter is the release cycle currently used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2261: [BPH] added ParkingDoubleMuonLowMass (8 PDs, 4 Streams)
  • CMSHLT-2273: [BPH] added ParkingDoubleElectronLowMass (6 PDs, 3 Streams)
  • CMSHLT-2356: [HIG] emu control triggers for 4J2B-PNET triggers
  • CMSHLT-2357: [HIG] control triggers for boosted Hbb-PNET triggers
  • CMSHLT-2359: [TSG] cleanup of EventContent of DQM stream
  • CMSHLT-2362: [BPH] ParkingSingleMuon PD for 2022
  • CMSHLT-1716: [TSG] set ThroughputService.dqmPathByProcesses to True
  • CMSHLT-2371: [TSG] backup seeds for Scouting Path
  • CMSHLT-2358: [JME] added AlCaRawLowPt stream for low pT jets
  • CMSHLT-2390: [TSG] merging of Muon and JetMET datasets (SingleMuon+DoubleMuon=Muon, JetHT+MET=JetMET)
  • CMSHLT-2361: [EXO] triggers for displaced dimuons with large lifetimes
  • CMSHLT-2382: [EXO] backup and monitoring triggers for displaced dimuons with large lifetimes
  • CMSHLT-2349: [HIG] update of VBF-tau monitoring triggers (mu+tau)
  • CMSHLT-2398: [JME] changed PS of HLT_Photon30EB_TightID_TightIso from 150 to 6
  • CMSHLT-2401: [TSG] added drop * statement to AlCaPPS EventContent
  • CMSHLT-2391: [TSG] cleanup of GRun menu (removal of disabled triggers)
  • CMSHLT-2404: [RPC] update of maxEta cut in AlCa_RPCMuonNormalisation triggers
  • CMSHLT-2403: [TSG] re-align offline menu with online (seed and PS of GPU-DQM Paths, splitting of Ephemeral PDs)
  • CMSHLT-2400: [JME] added PFJet110 control trigger
  • CMSHLT-2402: [HIG] update of HLTMonitor PD and stream for HLT-PNET monitoring
  • CMSHLT-2406: [BPH] enable new dimuon exclusive triggers (only for double-muon Parking PDs)
  • CMSHLT-2407: [TSG] use noise-cleaned e/gamma SigmaIEtaIEta for Scouting

In addition, the input file used for the HLT-Validation tests in IBs is updated to a recent collisions run:
/store/data/Run2022B/HLTPhysics0/RAW/v1/000/355/558/00000/cd851cf4-0fca-4d76-b80e-1d33e1371929.root

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

12_4_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38816/31191

  • This PR adds an extra 892KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee54f0/26376/summary.html
COMMIT: 97c73fe
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38816/26376/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano.log

RelVals-INPUT

  • 11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+RecoNano+HARVESTNano/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+RecoNano+HARVESTNano.log

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19868
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38816/31195

  • This PR adds an extra 892KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38816 was updated. @jpata, @missirol, @cmsbuild, @clacaputo, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

The new HLT menu required an update of the function customizeHLTIter0ToMkFit used in wf 11634.7.

@cms-sw/reconstruction-l2 , this PR and its backport (#38817) now require your signature.

@missirol missirol changed the title HLT menu development for 12_4_X (5/N): HLT V1.3 HLT menu development for 12_4_X (5/N): HLT V1.3 [12_5_X] Jul 21, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee54f0/26384/summary.html
COMMIT: d9f638e
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38816/26384/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19876
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19840
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee54f0/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee54f0/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3658754
  • DQMHistoTests: Total failures: 1549
  • DQMHistoTests: Total nulls: 55
  • DQMHistoTests: Total successes: 3657128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -22599.772 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1168.644 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -1104.990 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -751.112 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -307.692 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -234.379 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): -137.110 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 92.993 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0,... ): -34.929 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -30.352 KiB HLT/HLTJETMET
  • DQMHistoSizes: changed ( 11634.0,... ): -29.375 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 6 / 50 workflows

@missirol
Copy link
Contributor Author

+hlt

  • differences in outputs of PR tests are in line with updates to the GRun HLT menu

@missirol
Copy link
Contributor Author

@cms-sw/reconstruction-l2 , please review the minor change in RecoTracker/MkFit added as part of this PR.

HLT would like to have this PR tested in the next IB if possible.

@missirol
Copy link
Contributor Author

I learned that there is some history behind this MkFit customisation, see here and here, incl. an agreement that this customisation should not slow down the integration of HLT updates.

@clacaputo @jpata , please consider reviewing and signing.

@cms-sw/orp-l2 , I ask to consider this PR for the next IB regardless of the RECO signature (based on the aforementioned agreement). I would prefer to have this PR merged by 11:00, because another HLT PR needs to be prepared on top of this one (but not backported, unlike this one).

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

@cms-sw/orp-l2 , a kind ping for the review of this PR.

HLT would like to test this in the next IB (23:00).

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants