MessageLogger no longer prints summary by default

[Dr15Jones]

PR description:

• The option is still available to turn on in the configuration.
• Always print number of dropped messages if any were dropped.

PR validation:

Code compiles and framework unit test pass.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38805/31161

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/unit_test_outputs/testSubProcess.grep.txt modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/MessageService/test/u20_cfg.py modified in PR(s): Implement ResourceInformationService #37831
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): [DO-NOT merge] Revert "Enforce Modifier consistency between Process instances" #37996

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Integration (core)
• FWCore/MessageService (core)
• FWCore/ParameterSet (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

What if m_stream_ps contains both cerr and cout? Would it still be appropriate to print the message in both?

[Dr15Jones]

If that would be the case (and I don't think I've found a case where that is actually done) maybe they are redirecting output to two different files than both messages could still be useful. But I'm not wedded to the idea.

[Dr15Jones]

@makortel Do you want to have this changed to only output to cerr if both cerr and cout are active or keep it as it is?

[makortel]

Let's leave it as it is.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5766ef/26355/summary.html
COMMIT: 85ab8e7
CMSSW: CMSSW_12_5_X_2022-07-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38805/26355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1