Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] HeavyFlavor DQM fixes #38799

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

elusian
Copy link

@elusian elusian commented Jul 20, 2022

PR description:

This is a collection of small fixes for the recently merged HeavyFlavorDQM.
It also adds a customiser to allow running the DQM module from miniAOD instead of AOD

PR validation:

Fixes tested on the workflow 1366.0 which uses this module. Customisation tested on Early Run3 miniAOD data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38791

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2022

A new Pull Request was created by @elusian for CMSSW_12_4_X.

It involves the following packages:

  • DQM/Physics (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2022

backport of #38791

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2022

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dc69b/26344/summary.html
COMMIT: dc82e73
CMSSW: CMSSW_12_4_X_2022-07-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38799/26344/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2022

test parameters:

  • workflows = 1347, 1349, 1350, 1364, 1365, 1366, 136.884, 136.896, 136.860, 136.898
  • relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,cleanedupgrade,ged

@mmusich
Copy link
Contributor

mmusich commented Jul 20, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0dc69b/26351/summary.html
COMMIT: dc82e73
CMSSW: CMSSW_12_4_X_2022-07-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38799/26351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/1347.0_Upsilon1SToMuMu_13+Upsilon1SToMuMu_13+DIGIUP15+RECOUP15_BPHDQM+HARVESTUP15
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/1349.0_BsToMuMu_13+BsToMuMu_13+DIGIUP15+RECOUP15_BPHDQM+HARVESTUP15
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/1350.0_JpsiMuMu_Pt-8+JpsiMuMu_Pt-8+DIGIUP15+RECOUP15_BPHDQM+HARVESTUP15
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/136.86_RunCharmonium2018A+RunCharmonium2018A+HLTDR2_2018+RECODR2_2018reHLT_skimCharmonium_Offline+HARVEST2018_skimCharmonium
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/136.884_RunCharmonium2018C+RunCharmonium2018C+HLTDR2_2018+RECODR2_2018reHLT_skimCharmonium_Offline+HARVEST2018_skimCharmonium
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/136.896_RunCharmonium2018D+RunCharmonium2018D+HLTDR2_2018+RECODR2_2018reHLT_skimCharmonium_Prompt+HARVEST2018_skimCharmonium_Prompt
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/1364.0_BdToMuMu_13+BdToMuMu_13+DIGIUP15+RECOUP15_BPHDQM+HARVESTUP15
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0dc69b/1365.0_BuToJpsiK_13+BuToJpsiK_13+DIGIUP15+RECOUP15_BPHDQM+HARVESTUP15

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 60
  • DQMHistoTests: Total histograms compared: 4373562
  • DQMHistoTests: Total failures: 1190
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4372337
  • DQMHistoTests: Total skipped: 34
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.9670000000000003 KiB( 59 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1347.0,... ): 0.219 KiB Physics/HeavyFlavor
  • Checked 248 log files, 57 edm output root files, 60 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • changes caused by change in label/range of the plots

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

urgent

  • I understand that this should go into the next 12_4_X as well

@qliphy
Copy link
Contributor

qliphy commented Jul 22, 2022

+1

@cmsbuild cmsbuild merged commit f59f8d9 into cms-sw:CMSSW_12_4_X Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants