[12_4_X]Skip PPS diamond calibration if there are no parameters

[ChrisMisan]

PR description:

There was a possibility of crash in:

cmssw/RecoPPS/Local/src/CTPPSDiamondRecHitProducerAlgorithm.cc

Line 77 in 2a0aaba

ch_t_twc = calib_fct_->evaluate(std::vector<double>{tot}, ch_params);

if the calibration was not produced for a given channel. This fix adds the condition to handle this scenario.

PR validation:

Can be validated with relval 1041

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38763

[ChrisMisan]

type bug-fix, ctpps

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X.

It involves the following packages:

• RecoPPS/Local (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@forthommel, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Skip PPS diamond calibration if there are no parameters #38763

[ChrisMisan]

urgent

• backport is urgent

[ChrisMisan]

test parameters:

workflow = 1041

[ChrisMisan]

please test

[ChrisMisan]

backport of #38763

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107168/26277/summary.html
COMMIT: 9ec5074
CMSSW: CMSSW_12_4_X_2022-07-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38766/26277/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @qliphy Add missing line for SubProcess unit test diff #38756
• @makortel [12_4_X] Preprocess EDAlias and SwitchProducer information for ConditionalTask #38731
• @fwyzard fix Radix Sort for size = N*256+1 [12.4.x] #38747
• @Dr15Jones Avoid ID collisions between ED and ES modules in MessageLogger [12_4] #38742
• @eyigitba [12_4_X] Emtf Unpacker/Emulator Update for Run 3 CSC TPs #38625

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107168/26277/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107168/26277/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestSubProcess had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-107168/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3676399
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3676375
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

@jpata @clacaputo this unit test is known to be invalid. Please consider signing this. This fix is urgently needed.

[fwyzard]

@jpata @clacaputo this unit test is known to be invalid. Please consider signing this. This fix is urgently needed.

I agree that any failure in TestSubProcess should be unrelated to this PR, but could you point to any know failures of that test ?

[ChrisMisan]

@fwyzard yes, for example it recently failed in #38765
it was also discussed here: #38756

[fwyzard]

Thanks for the pointers !

[clacaputo]

+reconstruction

• error in TestSubProcess unit test not related to this PR, it's been seen also in other PRs [12_4_X]Skip PPS diamond calibration if there are no parameters #38766 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

please test
the unit failure should be fixed by #38767 now

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-107168/26307/summary.html
COMMIT: 9ec5074
CMSSW: CMSSW_12_4_X_2022-07-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38766/26307/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-107168/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3676486
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3676450
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[perrotta]

+1