Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add GEM alignment in all Run3 GTs and update BeamSpot in Run3 MC GTs" #38762

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

perrotta
Copy link
Contributor

Reverts #38692

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2022

just for the record, if #38760 comes to pass this one should not be necessary

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38762/31087

  • This PR adds an extra 8KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

just for the record, if #38760 comes to pass this one should not be necessary

@mmusich
since I doubt #38760 will be able to collect all needed signatures by this evening, let me revert this PR now: you can add these new GTs in that PR of yours, so that all changes can be merged together. Would you agree with it?

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2022

Would you agree with it?

Fine, I won't be able to follow-up on #38760 tomorrow, but since the base branch is from a VO I think @francescobrivio can push more commits after the rebase.

@perrotta
Copy link
Contributor Author

@cmsbuild cmsbuild merged commit 2a0aaba into master Jul 15, 2022
@smuzaffar smuzaffar deleted the revert-38692-alca-GEMAlignment branch September 24, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants