Fix SteppingAction for volume names with DD4hep

[hahnjo]

PR description:

This PR fixes the SteppingAction code for volume names when the geometry is created via DD4hep. The volume pointers are later used to check if a particle transitions from the Tracker to the CALO.

PR validation:

In local runs, the log now correctly includes

SteppingAction: pointer for Tracker 0x7f56d5508fd0 and for Calo 0x7f56d5509020

whereas before the pointers were 0 if the geometry was constructed via DD4hep.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Possibly many. I'll let Vladimir comment on this.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38706/31003

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @hahnjo (Jonas Hahnfeld) for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[civanch]

type bug

[perrotta]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a4ecc/26173/summary.html
COMMIT: a4bf4af
CMSSW: CMSSW_12_5_X_2022-07-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38706/26173/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3653734
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3653704
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

the fix is correct but there is no effect on hits/digi, which is seen in the regression. Extra tests are needed in order to understand if backport is needed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[civanch]

hold

[cmsbuild]

Pull request has been put on hold by @civanch
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[civanch]

@hahnjo , the fact that results show good regression does not mean that the problem is fully resolved. Let us fix more lines.

[civanch]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[civanch]

Because it is merged already I will do following in the morning: prepare extra fixes and make 12_4_X backport of two PRs. This PR is correct but incomplete.