Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noise plot and change thresholds [12_4_X] #38705

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Jul 12, 2022

PR description:

In response to the Run 3 collision conditions, this PR makes some adjustments in the Ecal DQM:

  1. Adds a plot to see the 2D distribution of the mean of presample noise.
  2. Increases x range and nbins of the 1D distribution of the noise mean.
  3. Adjusts the energy threshold for the timing plot in the forward region of Ecal endcaps.

PR validation:

This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.

This is a backport. Master PR: #38703

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2022

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@abhih1 abhih1 changed the title Add noise plot and change thresholds Add noise plot and change thresholds [12_4_X] Jul 12, 2022
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1620a1/26185/summary.html
COMMIT: f2c2ffe
CMSSW: CMSSW_12_4_X_2022-07-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38705/26185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676111
  • DQMHistoTests: Total failures: 628
  • DQMHistoTests: Total nulls: 1028
  • DQMHistoTests: Total successes: 3674433
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 905.6740000000003 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 11.250 KiB EcalBarrel/EBPedestalOnlineClient
  • DQMHistoSizes: changed ( 1000.0,... ): 10.459 KiB EcalBarrel/EBSummaryClient
  • DQMHistoSizes: changed ( 1000.0,... ): 5.625 KiB EcalEndcap/EEPedestalOnlineClient
  • DQMHistoSizes: changed ( 1000.0,... ): 3.896 KiB EcalEndcap/EESummaryClient
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #38703

@qliphy
Copy link
Contributor

qliphy commented Jul 16, 2022

+1

@cmsbuild cmsbuild merged commit 258d73d into cms-sw:CMSSW_12_4_X Jul 16, 2022
@abhih1 abhih1 deleted the AddNoisePlots_124X branch May 4, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants