-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.2.X] Refactoring gen weight storage in EDM + Nano integration #38699
[12.2.X] Refactoring gen weight storage in EDM + Nano integration #38699
Commits on Jul 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e90d7e - Browse repository at this point
Copy the full SHA 4e90d7eView commit details -
Working on parsing integration with scale/pdf weights
overhaul of code: now works with tinyxml2 instead of regex
Configuration menu - View commit details
-
Copy full SHA for a019e8a - Browse repository at this point
Copy the full SHA a019e8aView commit details -
New WeightGroups, improved parsing with helper class
Dylan's improvements of weight parsing changed LHEsource so it compiles, running tests now added scientific notation for numbers so values are correct added a few more test statements. Need to think of future needs Add testing suite (will remove/squash commits right before merge) Change pdfSetsInfo to be read in from LHAPDF path Still lingering question of how to decide pdf type This can be resolved in the new function "setupPdfSetsInfo" Add check if orphan weight is pdf and fix xml tag swap (needs review) Allow reading '>' as '>' and fix bug with first weight w/o group As for the first weight error: if the first weight doesn't have a weight group, the code would not add it to the list of weights because of currentGroupName and the first weight both having a trivial "" as their name. Thats the reason for the currentGroupName being set to "None" for initialization Fix space issue in regex and moved unchaning variables outside for Add pdfgroup splitting. To do this, needed LHAPDF requirements clang format Fix parsing issue with pdfweights in certain files those files being "DrellYan_LO_MGMLMv233_2016_weightInfo.txt" and "DrellYan_NLO_MGFXFXv242_2017_weightInfo.txt", Remove PdfSetInfo in favor of LHAPDF library Refactor pdfweight so pdfweights are always split May put flags needed for the splitting. Only impliemented in LHEWeightHelper Simplify ScaleWeight structure in anticipation of dyn weight changes Add dynWeights to scaleWeightInfo. Can improve code (basic refactor) Add orphaned pdf weight into scale weight missing central index not my finest work. Definitely could have improvements, but technically works Add Pdf info to pdfWeights (size, type) & check of size consistency More testing scripts, better error handling Fix orphaned central scale problem. was resizing to 1 (not great) Simplify logic of adding to make less opaque Move weight building logic to WeightHelper so GEN can use it Add basic GenLevel parsing. Works on ZGTo2NuG test file Add PartonShower parsing for GenWeights Change PartonShower filename to match h file More error handling, parsing improvements Add option for raising expection if XML is not valid Fix parsing of PartonShower name in GenWeights Add basic MEParam weight functionality Allow for general adding of params to vector Also fixed formating with clang Simplifications for PS and ME weight groups
Configuration menu - View commit details
-
Copy full SHA for daaf3ce - Browse repository at this point
Copy the full SHA daaf3ceView commit details -
updates to allow saving weight sums from all weight categories
adding option to save preferred PS weights Support unassociated LHE weights, simplify PS weights Refactor ScaleWeightGroup to simplify codebase Remove/change lines in WeightHelper to clean Fix naming problems in ScaleWeight Refactor LHWeightHelper (moved to helper functions) Fix errors in ScaleWeight and add print statements for debug
Configuration menu - View commit details
-
Copy full SHA for 20d886f - Browse repository at this point
Copy the full SHA 20d886fView commit details -
Fix off-by-one error in pdf weight splitting Templatize product adder in WeightHelper Expand emission functionality to PSWeight needs to add more to make sure works correctly clang-format the partonshowerWeightGroupInfo.cc file as well Fix central weight and error from mg26xNew Fix PSWeights in LumiHeader to work w diff pythia format
Configuration menu - View commit details
-
Copy full SHA for f71ab49 - Browse repository at this point
Copy the full SHA f71ab49View commit details -
Configuration menu - View commit details
-
Copy full SHA for b13136f - Browse repository at this point
Copy the full SHA b13136fView commit details -
Use cms::Exception, configure debugging, code formatting
Further cleanup, nano improvements change way PS weights handled Allow for finding missing weights Fix error with gap fixing code Change around logic to have bool to decide if use guess for PS Amend wellformed logic for scaleweight Cleanup code Nano back to GenWeightsTableProducer file
Configuration menu - View commit details
-
Copy full SHA for 156617a - Browse repository at this point
Copy the full SHA 156617aView commit details -
attempt to delete extra kets after the last </weightgroup>
fix runtime error failIfInvalidXML_ cleanup failIfInvalidXML_ cleanup (2) scram b code-format
Configuration menu - View commit details
-
Copy full SHA for 37e4dad - Browse repository at this point
Copy the full SHA 37e4dadView commit details -
Step forward to newer cmssw version
Fix problem of confounding issues in xmlParsing code fails to parse correctly when swapped weigthgroup tags and escaped </> characters in header. Also clean up the xmlError parsing and add some debug statements associated with tose errors falling back to vector of flattables Add "fillEmptyIfWeightFails" option and fix an err Error is related to the product size not being updated when an unknown weight is found Add more error states to LHEWEightHelper to handle empty xml
Configuration menu - View commit details
-
Copy full SHA for 0438535 - Browse repository at this point
Copy the full SHA 0438535View commit details -
Configuration menu - View commit details
-
Copy full SHA for d27b812 - Browse repository at this point
Copy the full SHA d27b812View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7f352 - Browse repository at this point
Copy the full SHA bc7f352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 543c4ba - Browse repository at this point
Copy the full SHA 543c4baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56c6a7e - Browse repository at this point
Copy the full SHA 56c6a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78aaa8b - Browse repository at this point
Copy the full SHA 78aaa8bView commit details -
Code format, don't fail for missing LHEEventProduct
Remove redundant files (renamed or dropped) revert unneeded change Produce new LHEEventProduct with weights zeroed Can also be done for GenEventInfoProduct, but here the number of floats duplicated is way less severe, and the amount of downstream code accessing it is way larger Code format
Configuration menu - View commit details
-
Copy full SHA for c95bdba - Browse repository at this point
Copy the full SHA c95bdbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 871b024 - Browse repository at this point
Copy the full SHA 871b024View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15b0b4e - Browse repository at this point
Copy the full SHA 15b0b4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8689e3b - Browse repository at this point
Copy the full SHA 8689e3bView commit details -
Fix case where weight lumi product doesn't exist but event weight does Remove allowUnassociated for LHE, Code format
Configuration menu - View commit details
-
Copy full SHA for c8a9816 - Browse repository at this point
Copy the full SHA c8a9816View commit details -
Attempt to fit cosmics workflow error
Treat unassociated weights properly Code checks
Configuration menu - View commit details
-
Copy full SHA for cd7c306 - Browse repository at this point
Copy the full SHA cd7c306View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eed38e - Browse repository at this point
Copy the full SHA 5eed38eView commit details -
macro to permit catch statement with LHAPDF
code format
Configuration menu - View commit details
-
Copy full SHA for 9e8ec88 - Browse repository at this point
Copy the full SHA 9e8ec88View commit details -
Configuration menu - View commit details
-
Copy full SHA for a118207 - Browse repository at this point
Copy the full SHA a118207View commit details