-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_4_X] Adding HZZ electron MVA ID #38698
[12_4_X] Adding HZZ electron MVA ID #38698
Conversation
A new Pull Request was created by @asculac (Ana Sculac) for CMSSW_12_4_X. It involves the following packages:
@gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
backport of #38355 |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT
|
Pull request #38698 was updated. @gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please check and sign again. |
I forgot to set mvaHZZIso to None also for run3_nanoAOD_devel, I apologize for this overlook. It should be okay now |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64cfc/26169/summary.html Comparison SummarySummary:
|
+xpog |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #38355
adding HZZ training for electron ID, which is an EGgamma-approved ID (latest talk at egamma POG here ) used for H->4l, which cannot otherwise be recomputed on top of nanoAODs.
It is based on the same electronMVAValueMapProducer used for existing mvaIds, but with an updated and separate training for 2016UL, 2017UL and 2018UL.
A single variable mvaHZZIso is added to electrons. The appropriate training to be used is selected automatically. The idea is that the variable name will stay the same in the future, selecting a new training when appropriate.
No need to store working points as bools since these can be easily derived from the MVA value.
In addition to this PR: renaming mva Egamma IDs to be more generic
PR validation:
This PR is a backport of #38355