[12_3_X] Add protection vs Minuit2 Fatal Root Error and update VxErrCorr in Vx3DHLTAnalyzer

[francescobrivio]

PR description:

Backport of #38687
This PR fixes the beampixel DQM client crashes observed recently, see master PR for detailed description

PR validation:

Code compiles + private tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38687

FYI @dinardo

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)
• DQM/Integration (dqm)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add protection vs Minuit2 Fatal Root Error and update VxErrCorr in Vx3DHLTAnalyzer #38687

[francescobrivio]

backport of #38687

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@emanueleusai @ahmad3213 @rvenditti could you please test this PR in the Playback system with a recent collision run where the beampixel client was crashing?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd8d14/26145/summary.html
COMMIT: d203acf
CMSSW: CMSSW_12_3_X_2022-07-11-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38689/26145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626403
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3626379
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

@francescobrivio thank you for the heads up, we will test once #38687 (comment) is addressed

[cmsbuild]

Pull request #38689 was updated. @malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[francescobrivio]

@francescobrivio thank you for the heads up, we will test once #38687 (comment) is addressed

@emanueleusai the comment was addressed in the last push

[tvami]

type bugfix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd8d14/26170/summary.html
COMMIT: 1b0f4af
CMSSW: CMSSW_12_3_X_2022-07-12-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38689/26170/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626403
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3626367
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• tests pass
• PR is according to the description

[francescobrivio]

@emanueleusai did you have the chance to test this PR at P5?
This fixes the crashes of the beampixel client, so ot would be good to have it in production soon.
Thanks!

[emanueleusai]

testing at p5

[emanueleusai]

tested successfully, to be deployed soon

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1