Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers not being set properly in EventConfig for data (backport of #38622, 12_3_X) #38678

Conversation

seungjin-yang
Copy link
Contributor

@seungjin-yang seungjin-yang commented Jul 11, 2022

PR description:

This PR is a backport of #38622. This PR intoduces the lazy import of Configuration.EventContent.EventContent_cff to avoid calling Modifier.toModify before Process.__init__. The issue is well described in #38622.

PR validation:

Same as #38622.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #38622. This fix should be applied to releases for Run2022.

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2022

A new Pull Request was created by @seungjin-yang (Seungjin Yang) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @rappoccio, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jul 11, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e412f/26125/summary.html
COMMIT: 41d564b
CMSSW: CMSSW_12_3_X_2022-07-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38678/26125/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2994 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3626403
  • DQMHistoTests: Total failures: 7703
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618678
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@perrotta
Copy link
Contributor

backport of #38622

@qliphy
Copy link
Contributor

qliphy commented Jul 12, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 213c6e2 into cms-sw:CMSSW_12_3_X Jul 12, 2022
@seungjin-yang
Copy link
Contributor Author

@perrotta can you let me know when this fix will be applied to T0?

@perrotta
Copy link
Contributor

@perrotta can you let me know when this fix will be applied to T0?

One of the item to be discussed at today's ORP meeting (https://indico.cern.ch/event/1179450/) is exactly whether and when a new 12_3_X release will be needed, and by whom (i.e. T0). Even if we decide to build a new release, it will last just a few days, since the plan is to move T0 to 12_4 soon.

@seungjin-yang
Copy link
Contributor Author

@perrotta Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants