[12.3.X] Add `DiMuonVertexMonitor` module and use it for `ALCARECOTkAlDiMuonAndVertexDQM` #38644

mmusich · 2022-07-07T22:29:33Z

PR description:

PR #33770 added a new ALCARECO producer (ALCARECOTkAlDiMuonAndVertex).
This PR adds the DQM monitoring for that stream and adds a new DQM Analyzer (DiMuonVertexMonitor) to monitor the properties of the selected di-muon vertices.
I profit of this PR to make a clean-up of the TkAlCaRecoMonitor module as well in commit 2931aac.

PR validation:

Run successfully a modified version of 136.887 to include the TkAlDiMuonAndVertex ALCARECO producer.

if this PR is a backport please specify the original PR and why you need to backport that PR:

almost verbatim backport of #38378 + #38463 (needed to change GT and input files in the unit tests).
I am opening since there is a window for a new release to be used at Tier-0 - no big hopes of getting it in, though.

cmsbuild · 2022-07-07T22:29:57Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

Configuration/StandardSequences (operations)
DQMOffline/Alignment (dqm)

@perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2022-07-07T22:30:52Z

type new-feature

mmusich · 2022-07-07T22:31:05Z

please test

cmsbuild · 2022-07-08T02:54:43Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8c6c9/26071/summary.html
COMMIT: ec3c471
CMSSW: CMSSW_12_3_X_2022-07-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38644/26071/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDiMuonVertexMonitor had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3626403
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3626372
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 289.962 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): 289.946 KiB AlCaReco/TkAlDiMuonAndVertex
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-07-08T06:11:23Z

Pull request #38644 was updated. @perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again.

mmusich · 2022-07-08T06:11:51Z

@cmsbuild, please test

cmsbuild · 2022-07-08T10:03:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8c6c9/26073/summary.html
COMMIT: d9b01a4
CMSSW: CMSSW_12_3_X_2022-07-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38644/26073/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3626403
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3626372
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 289.95799999999997 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): 289.946 KiB AlCaReco/TkAlDiMuonAndVertex
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-07-11T12:40:25Z

+1

qliphy · 2022-07-19T01:00:07Z

please test

cmsbuild · 2022-07-19T07:46:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8c6c9/26317/summary.html
COMMIT: d9b01a4
CMSSW: CMSSW_12_3_X_2022-07-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38644/26317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3626490
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3626465
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 289.962 KiB( 48 files compared)
DQMHistoSizes: changed ( 1000.0 ): 289.946 KiB AlCaReco/TkAlDiMuonAndVertex
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

mmusich · 2022-07-25T20:33:38Z

...what's the objection in merging this?

qliphy · 2022-07-26T02:02:03Z

@mmusich As mentioned in last ORP, we plan to close 12_3_X as 12_4_X is now deployed. This can be discussed again at today's ORP though.

perrotta · 2022-07-26T05:32:35Z

...what's the objection in merging this?

@mmusich what's the purpose of merging in 12_3_X?

mmusich · 2022-07-26T08:55:18Z

what's the purpose of merging in 12_3_X

E.g. validation of private samples produced in this cycle...

mmusich · 2022-07-26T08:56:45Z

@qliphy

As mentioned in last ORP, we plan to close 12_3_X as 12_4_X is now deployed

Not everyone follows all ORP meetings. Also it seems this stayed idle for 20 days before you reached that conclusion

perrotta · 2022-08-23T07:47:28Z

Verbatim backport of #38378 and #38463

perrotta · 2022-08-23T07:49:35Z

@mmusich we are empting the queues for the to be closed cycles 12_2_X and 12_3_X.
Do you still need this PR being merged in the 12_3_X IB for your "validation of private samples produced in this cycle"? If so, it can be merged. Otherwise, we will close it.
Please let us know.

mmusich · 2022-08-23T15:12:51Z

Otherwise, we will close it.

let's close it. Unfortunately it didn't make it in time to 12.3.x to be useful.

cmsbuild added this to the CMSSW_12_3_X milestone Jul 7, 2022

cmsbuild added dqm-pending operations-pending orp-pending pending-signatures tests-pending labels Jul 7, 2022

cmsbuild added new-feature tests-started and removed tests-pending labels Jul 7, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 8, 2022

mmusich added 6 commits July 8, 2022 08:01

clean-up TkAlCaRecoMonitor

c0a0999

introduce DiMuonVertexMonitor DQMEDAnalyzer

ed1cd86

add DQM monitoring for ALCARECOTkAlDiMuonAndVertex producer

369bbbe

code-checks & code-format

df07eaa

add impact parameter plots to DiMuonVertexMonitor

64b8122

add unit test to DQMOffline/Alignment package

d9b01a4

mmusich force-pushed the addDiMuonVertexMonitor_12_3_X branch from ec3c471 to d9b01a4 Compare July 8, 2022 06:10

cmsbuild added tests-pending and removed tests-rejected labels Jul 8, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2022

cmsbuild removed the tests-started label Jul 8, 2022

cmsbuild added the tests-approved label Jul 8, 2022

cmsbuild added dqm-approved and removed dqm-pending labels Jul 11, 2022

cmsbuild added tests-started and removed tests-approved labels Jul 19, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 19, 2022

mmusich closed this Aug 23, 2022

mmusich deleted the addDiMuonVertexMonitor_12_3_X branch August 23, 2022 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.3.X] Add `DiMuonVertexMonitor` module and use it for `ALCARECOTkAlDiMuonAndVertexDQM` #38644

[12.3.X] Add `DiMuonVertexMonitor` module and use it for `ALCARECOTkAlDiMuonAndVertexDQM` #38644

mmusich commented Jul 7, 2022 •

edited

Loading

cmsbuild commented Jul 7, 2022

mmusich commented Jul 7, 2022

mmusich commented Jul 7, 2022

cmsbuild commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

mmusich commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

emanueleusai commented Jul 11, 2022

qliphy commented Jul 19, 2022

cmsbuild commented Jul 19, 2022

mmusich commented Jul 25, 2022

qliphy commented Jul 26, 2022

perrotta commented Jul 26, 2022

mmusich commented Jul 26, 2022

mmusich commented Jul 26, 2022

perrotta commented Aug 23, 2022

perrotta commented Aug 23, 2022

mmusich commented Aug 23, 2022

[12.3.X] Add DiMuonVertexMonitor module and use it for ALCARECOTkAlDiMuonAndVertexDQM #38644

[12.3.X] Add DiMuonVertexMonitor module and use it for ALCARECOTkAlDiMuonAndVertexDQM #38644

Conversation

mmusich commented Jul 7, 2022 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 7, 2022

mmusich commented Jul 7, 2022

mmusich commented Jul 7, 2022

cmsbuild commented Jul 8, 2022

Unit Tests

Comparison Summary

cmsbuild commented Jul 8, 2022

mmusich commented Jul 8, 2022

cmsbuild commented Jul 8, 2022

Comparison Summary

emanueleusai commented Jul 11, 2022

qliphy commented Jul 19, 2022

cmsbuild commented Jul 19, 2022

Comparison Summary

mmusich commented Jul 25, 2022

qliphy commented Jul 26, 2022

perrotta commented Jul 26, 2022

mmusich commented Jul 26, 2022

mmusich commented Jul 26, 2022

perrotta commented Aug 23, 2022

perrotta commented Aug 23, 2022

mmusich commented Aug 23, 2022

[12.3.X] Add `DiMuonVertexMonitor` module and use it for `ALCARECOTkAlDiMuonAndVertexDQM` #38644

[12.3.X] Add `DiMuonVertexMonitor` module and use it for `ALCARECOTkAlDiMuonAndVertexDQM` #38644

mmusich commented Jul 7, 2022 •

edited

Loading