Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Add VtxSmearing scenario for Run 3 early data at 13.6 TeV #38617

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #38616
This PR adds the realistic vertex smearing scenario for 2022 early data at 13.6 TeV: Realistic25ns13p6TeVEarly2022Collision.
Parameters used:

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38616

FYI @dzuolo @gennai @mmusich @rappoccio @cms-sw/pdmv-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @civanch, @mdhildreth, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

urgent

  • to be included in next 12_4_X release for MC production

@cmsbuild cmsbuild added the urgent label Jul 6, 2022
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@tvami
Copy link
Contributor

tvami commented Jul 6, 2022

backport of #38616

@civanch
Copy link
Contributor

civanch commented Jul 6, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-03f489/26011/summary.html
COMMIT: acee088
CMSSW: CMSSW_12_4_X_2022-07-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38617/26011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675848
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675812
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2022

+1

  • Let test both the master version and this 12_4_X backport in the IB at the same time. If tomorrow there are no issues from both them, we can start building the CMSSW_12_4_X release with this vertex smearing scenario for the MC production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 8166290 into cms-sw:CMSSW_12_4_X Jul 6, 2022
@francescobrivio francescobrivio deleted the alca-MC_production_12_4_X branch July 7, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants