Fix bug in muon index bit computation

[dinyar]

PR description:

We were previously only doing the data format-based assignment for BMTF muons. This is now extended to also OMTF and EMTF muons. This will mostly have an effect on the DQM, removing uGMT data-emulator mismatches during cosmics data taking. (cc @pmandrik; I will also create backports to 12_4_X and 12_3_X imminently and would request deployment to the online DQM if everything is fine.)

PR validation:

Ran on RAW data locally and confirmed that the index bit mismatches went away.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38532/30765

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TMuon/plugins/L1TMuonProducer.cc modified in PR(s): Bph reco refactored 12 4 x #38525

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ace95f/25862/summary.html
COMMIT: 00db3bf
CMSSW: CMSSW_12_5_X_2022-06-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38532/25862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659995
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3659971
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[dinyar]

Hi @cecilecaillol, @epalencia,

Is this (and the backports) fine to go in?

Also reminder to @pmendrik that it would be great if this could go into the online DQM (it doesn't need to go in before 5 July as it only affects cosmic running).

Finally attn @vukasinmilosevic as it fixes L1T DQM data-emu comparisons.

Cheers,
Dinyar

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1