-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Phase-2 bricked pixels specific reconstruction code from CMSSW #38529
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30758
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30759
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@perrotta, @clacaputo, @cmsbuild, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
OK, running |
@cmsbuild , please test |
type performance-improvement,trk |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbd55d/25854/summary.html Comparison SummarySummary:
|
+reconstruction
|
@cms-sw/operations-l2 this is essentially fully signed |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Resolves #35519
The Phase-2 bricked pixels design was discarded, this PR removes the code from CMSSW
PR validation:
doing
leads to
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A