Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalDQM: Add FED integrity module, backport to 12_4_X #38492

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

lwang046
Copy link
Contributor

PR description:

Add HCAL FED integrity monitoring module, backport of PR #38387 to 12_4_X upon request.

PR validation:

Testes and verified with actual data from recent Run#352567

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2022

A new Pull Request was created by @lwang046 for CMSSW_12_4_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@DryRun, @battibass, @abdoulline, @bsunanda, @francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type hcal

@cmsbuild cmsbuild added the hcal label Jun 25, 2022
@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

backport of #38387

@emanueleusai
Copy link
Member

type feature

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79051a/25778/summary.html
COMMIT: d32c607
CMSSW: CMSSW_12_4_X_2022-06-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38492/25778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8afa232 into cms-sw:CMSSW_12_4_X Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants