-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix size of arrays in MillePedeDQMModule to store new HG thresholds #38367
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38367/30553
|
A new Pull Request was created by @dmeuser for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
resolves #38364 |
const std::array<double, 6>& sigCut, | ||
const std::array<double, 6>& maxMoveCut, | ||
const std::array<double, 6>& maxErrorCut, | ||
const std::array<double, 8>& cut, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a suggestion, since this number doesn't need to be different for the various arrays, could it be a named constant defined somewhere and then used everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, do you want me to change it in this PR or the in the upcoming one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe could be done directly here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please, do it here.
As such you can also better identify if anything is missing the update (for example: shouldn't also the dimensions and number of bins of the histos get modified accordingly?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same argument as below(#38367 (comment)). We want to keep the new HG alignment separated from the LG one, thus we will add additional histograms for the HG result in an upcoming PR. Most of the changes were already collected here: https://github.com/dmeuser/cmssw/tree/hgPCL_PR, where we still need some adaptions to make the next PR
const std::array<double, 8>& cut, | ||
const std::array<double, 8>& sigCut, | ||
const std::array<double, 8>& maxMoveCut, | ||
const std::array<double, 8>& maxErrorCut, | ||
const std::array<double, 6>& obs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why still "6"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the fillExpertHisto
method will only take care of the low granularity result, which has 6 different structures. We will add a new method in an upcoming PR to take care of the high granularity result.
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38367/30556
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
fbf3056
to
6b7b2f6
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38367/30558
|
@cmsbuild , please test for CMSSW_12_5_CLANG_X |
@cmsbuild , please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a85fdb/25526/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a85fdb/25525/summary.html Comparison SummarySummary:
|
@cms-sw/alca-l2 I think you can sign this, since you already did so for its 12_4_X backport #38371 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #38364
PR description:
Adressing issue #38364, by adjusting the array size of the threshold containers in
MillePedeDQMModule
to hold the new HG thresholds introduced in PR #38273 and #38195.