Shorten PPS DiamondSampic ALCARECOStream name to fit into DBS database schema

[francescobrivio]

PR description:

Due to the limitations of the DBS database schema (as described in https://cms-talk.web.cern.ch/t/alcaprompt-datasets-not-loaded-in-dbs/11146/2) and following the example of #38186, this PR shortens the only remaining ALCARECOStream name in autoPCL that was still too long:

• ALCARECOStreamPromptCalibProdPPSDiamondSampicTimingCalib
  is renamed
  ALCARECOStreamPromptCalibProdPPSDiamondSampic

PR validation:

Code compiles.
There are no data taken with PPS Diamond Sampic detector yet, so no relvals and no other test can be done at this point.
As soon as we get some data we will set up all the needed tests.

Backport:

Not a backport, but backports to 12_3_X and 12_4_X will be provided.

FYI @vavati @ChrisMisan @grzanka

[francescobrivio]

type pps

[francescobrivio]

type ctpps

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38209/30358

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)
• Configuration/AlCa (alca)
• Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

FYI @fabiocos

[francescobrivio]

@cmsbuild please test

[mmusich]

hold

• to avoid rebasing Shorten the names of two ALCARECOStreams in order to fit into DBS database schema limitations #38186

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[francescobrivio]

hold

* to avoid rebasing [Shorten the names of two ALCARECOStreams in order to fit into DBS database schema limitations #38186](https://github.com/cms-sw/cmssw/pull/38186)

@mmusich I was also expecting conflicts, but apparently GH doesn't think so.
In any case I 100% agree that your PR is much more urgent and should be merged first (and I'll take care of rebasing this PR if needed)!

[mmusich]

but apparently GH doesn't think so.

I don't quite understand this, as we are touching the same file: Configuration/AlCa/python/autoPCL.py

[francescobrivio]

but apparently GH doesn't think so.

I don't quite understand this, as we are touching the same file: Configuration/AlCa/python/autoPCL.py

I am puzzled as well: we are modifying different lines, but since i'm adding some comment lines at the top of the file the conflict should be there...

[grzanka]

I just wanted to understand the scope of renaming, from this PR I see that in some parts the old name stays intact (i.e. filename ALCARECOPromptCalibProdPPSDiamondSampicTimingCalib_Output_cff.py is not shortened). I remember there was a long debate on consistency for naming convention during the implementation of other AlCa producers for PPS (i.e. #36702). Are you sure that such partial renaming won't have any consequences, i.e. for Tier0 replay, which I believe cannot be quickly tested ?

[grzanka]

I remember also from that changes were needed in relvals, see:
https://github.com/cms-sw/cmssw/pull/36784/files#diff-b0dce787f15ea8526a7b5585e797ba4b9e17ba829550c8283b5b5f97cba58b04

Can you run some tests with:

runTheMatrix.py -l 1041 --ibeos
runTheMatrix.py -l 1042 --ibeos

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-604b5d/25214/summary.html
COMMIT: bfb21a3
CMSSW: CMSSW_12_5_X_2022-06-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38209/25214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3649923
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3649887
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

unhold

• Shorten the names of two ALCARECOStreams in order to fit into DBS database schema limitations #38186 is merged, and apparently still no conflicts (puzzled)

[tvami]

Hi @grzanka

• we needed PPS renaming AlCa Prompt producers and PPSCalTrackBasedSel AlCa Reco to autoAlca.py #36702 because T0 looks for the PromptCalibProd in the name.
• we didnt test here with 1041, 1042 because this given producer is not part of those wfs (you dont have input data...)
• the same was done for the Tk ALCARECOs, we we believe that this renaming is enough. The Tk part can be tested soon, and then when PPS finally joins a global collision run, we'll test these changes too

[tvami]

+alca

• technical change, renaming
• no relvals tests this, see my comment for future testing above

[tvami]

@cms-sw/orp-l2 we are essentially fully signed

[tvami]

urgent

• backport "needed" for datataking (whenever that happens for PPS)

[perrotta]

unhold

• Shorten the names of two ALCARECOStreams in order to fit into DBS database schema limitations #38186 is merged, and apparently still no conflicts (puzzled)

The changed lines were far away enough, and git is smart enough to recognize that they do not interfere each other

[mmusich]

The changed lines were far away enough, and git is smart enough to recognize that they do not interfere each other

fine, but I would have at least expected the bot to flag that the two PRs were changing the same files here

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.