-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_3_X] Use RAWEventContent parameter set for Repack output module #38017
[12_3_X] Use RAWEventContent parameter set for Repack output module #38017
Conversation
A new Pull Request was created by @germanfgv (Germán Felipe Giraldo Villa) for CMSSW_12_3_X. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@drkovalskyi Here is the backport. @qliphy could you please trigger the tests? |
allow @germanfgv test rights |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f62d05/24867/summary.html Comparison SummarySummary:
|
@perrotta @qliphy @davidlange6 All checks were successful. Can this be merged? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged. |
For the record, we just identified that this breaks the ALCARAW files, for example the ECALPhiSym (noticed in the replay |
@germanfgv @drkovalskyi Do you have any opinion on this? |
Should we revert this in 12_3_X, then? Or is it something you can deal with? |
We are working on it. Give us some time to finish a couple of tests to give the final answer later today. |
Let's revert 12_3_X. We will propose a proper solution on 12_4_X first and then make a back port. We can live a bit longer with wrong compression. |
@drkovalskyi just to be sure: are you proposing to revert this PR in 12_3_X? |
yes |
PR description:
Changes repack to use the defined RAWEventContent output module configuration.
PR validation:
None beyond the tests in #37791
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #37791. Needed to use the right compression algorithm during 900 GeV collisions.