Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Use RAWEventContent parameter set for Repack output module #38017

Merged
merged 1 commit into from
May 20, 2022

Conversation

germanfgv
Copy link
Contributor

PR description:

Changes repack to use the defined RAWEventContent output module configuration.

PR validation:

None beyond the tests in #37791

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37791. Needed to use the right compression algorithm during 900 GeV collisions.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @germanfgv (Germán Felipe Giraldo Villa) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@germanfgv
Copy link
Contributor Author

germanfgv commented May 19, 2022

@drkovalskyi Here is the backport. @qliphy could you please trigger the tests?

@germanfgv germanfgv changed the title Use RAWEventContent parameter set for Repack output module [12_3_X] Use RAWEventContent parameter set for Repack output module May 19, 2022
@qliphy
Copy link
Contributor

qliphy commented May 19, 2022

allow @germanfgv test rights

@qliphy
Copy link
Contributor

qliphy commented May 19, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f62d05/24867/summary.html
COMMIT: c2ea236
CMSSW: CMSSW_12_3_X_2022-05-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38017/24867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3628142
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3628112
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@germanfgv
Copy link
Contributor Author

@perrotta @qliphy @davidlange6 All checks were successful. Can this be merged?

@qliphy
Copy link
Contributor

qliphy commented May 20, 2022

+1
as requested by Tier0 offline to include LZMA4 RAW compression to be available before first collisions next week.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 68b8cd4 into cms-sw:CMSSW_12_3_X May 20, 2022
@tvami
Copy link
Contributor

tvami commented May 20, 2022

For the record, we just identified that this breaks the ALCARAW files, for example the ECALPhiSym (noticed in the replay
dmwm/T0#4664 )

@qliphy
Copy link
Contributor

qliphy commented May 20, 2022

For the record, we just identified that this breaks the ALCARAW files, for example the ECALPhiSym (noticed in the replay dmwm/T0#4664 )

@germanfgv @drkovalskyi Do you have any opinion on this?

@perrotta
Copy link
Contributor

For the record, we just identified that this breaks the ALCARAW files, for example the ECALPhiSym (noticed in the replay dmwm/T0#4664 )

Should we revert this in 12_3_X, then? Or is it something you can deal with?
Is any fix expected soon (i.e. by today)?

@drkovalskyi
Copy link
Contributor

We are working on it. Give us some time to finish a couple of tests to give the final answer later today.

@drkovalskyi
Copy link
Contributor

Let's revert 12_3_X. We will propose a proper solution on 12_4_X first and then make a back port. We can live a bit longer with wrong compression.

@perrotta
Copy link
Contributor

Let's revert 12_3_X. We will propose a proper solution on 12_4_X first and then make a back port. We can live a bit longer with wrong compression.

@drkovalskyi just to be sure: are you proposing to revert this PR in 12_3_X?

@drkovalskyi
Copy link
Contributor

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants