Fix for issue 37970 - address undetermined output of cand DNN in mkFit

[leonardogiannini]

PR description:

This PR addresses issue #37970

In the cand level DNN run after MkFit the output is undetermined if the propagation to the beamline is invalid. This happens in 0.1% of cases at most.

This behaviour is flagged and the output set to -1 (i.e. failing the selection).

I also added a check on ndof > 0 (used to divide chi2), which didn't create problems so far.

PR validation:

Example of difference in workflow 12434

no PR #37918 ------ | with PR #37918 ----- | fixed

0.951501 the output | 0.951501 the output | 0.951501 the output
0.931231 the output | 0.931231 the output | 0.931231 the output
0.877139 the output | 0.877139 the output | 0.877139 the output
0.557774 the output | 0.557774 the output | 0.557774 the output
0.97176 the output | 0.97176 the output | 0.97176 the output
0.761749 the output | -nan the output | -1 the output
0.485212 the output | 0.485212 the output | 0.485212 the output
-0.888864 the output | -0.888864 the output | -0.888864 the output
0.990027 the output | 0.990027 the output | 0.990027 the output
0.769534 the output | 0.769534 the output | 0.769534 the output
0.962413 the output | 0.962413 the output | 0.962413 the output

The physics changes in MTV validation are almost zero, as expected.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38004/30084

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/MkFit/plugins/MkFitOutputConverter.cc modified in PR(s): move TfGraphDefWrapper and TfGraphDefProducer from RecoTracker/FinalTrackSelectors to PhysicsTools/TensorFlow #37968

[cmsbuild]

A new Pull Request was created by @leonardogiannini for master.

It involves the following packages:

• RecoTracker/MkFit (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e3d6a/24837/summary.html
COMMIT: 927cc20
CMSSW: CMSSW_12_5_X_2022-05-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38004/24837/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672375
• DQMHistoTests: Total failures: 154
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

@leonardogiannini given the bug-fix looks uncontroversial, I've taken the liberty to make a backport at #38011

[mmusich]

type bug-fix

[jpata]

+reconstruction

• bugfix for DQM instability in 12434.0, pixelLessStep_quickAssociatorByHits #37970
• minor physics changes are expected (fixes occasional random values in DNN output)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1