Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC 4th endcap stations #37945

Merged
merged 2 commits into from
May 15, 2022
Merged

Add RPC 4th endcap stations #37945

merged 2 commits into from
May 15, 2022

Conversation

mileva
Copy link
Contributor

@mileva mileva commented May 13, 2022

PR description:

To add RPC 4th endcap stations. The code to be used for an RPC DPG analysis.

PR validation:

tested with runTheMatrix.py -l 11650.0
(1650.0_ZMM_14+2021+ZMM_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA)
exit: 0 0 0 0 0

Mention: @cms-sw/rpc-dpg-l2

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37945/30001

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37945/30002

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mileva for master.

It involves the following packages:

  • RecoLocalMuon/RPCRecHit (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d694b7/24715/summary.html
COMMIT: 1337b63
CMSSW: CMSSW_12_4_X_2022-05-13-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37945/24715/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697377
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697347
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

+reconstruction

  • the PR allows to use RPC station 4 in CSCObjectMap and CSCSegtoRPC::thePoints, used in RPCPointProducer, whose products are used by test or validation code
  • no reco changes observed or expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Ditto for the need to improve communications between RPC DPG and Offline...

@cmsbuild cmsbuild merged commit e3dc639 into cms-sw:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants