migrate PixelVTXMonitor to DQMEDAnalyzer

[mmusich]

PR description:

Title says it all. Part of the migration at #36404.
Besides removing the legacy type, modernized the code:

• merged implementation with header;
• removed unused methods;
• range-based loops
• modernized event data access;

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

---

Note to reviewers, there are other modules needing to be migrated in this package, but they do require substantially more work in order to guarantee thread safety. Those will be addressed at a second time.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37942/29992

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/BeamMonitor/plugins/PixelVTXMonitor.cc modified in PR(s): Migration of input collection parameters to untracked in DQM/BeamMonitor package #37848
  • File DQM/BeamMonitor/python/PixelVTXMonitor_cfi.py modified in PR(s): Migration of input collection parameters to untracked in DQM/BeamMonitor package #37848

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

test parameters:

• addpkg = DQM/Integration

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-968b3d/24697/summary.html
COMMIT: 35176eb
CMSSW: CMSSW_12_4_X_2022-05-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37942/24697/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697377
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697353
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• unit tests pass
• code changes are according to the PR description
• note: SA noticed some further possible clean-ups (dead assignments, legacy modules in BeamMonitorBx, AlcaBeamMonitorClient, BeamConditionsMonitor, and thread safety related fixes):
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-968b3d/24697/llvm-analysis/

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1