do not fetch PixelClusterCountsInEvent when the handle is not valid

[mmusich]

resolves #37685

PR description:

Trivial fix for #37685. Profited to make some clean-up of the class.

PR validation:

step2 of 1001.2 runs after the fix

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[tvami]

test parameters:

• workflows = 1001.2,1020

[mmusich]

do we have a wf to test when the product is avaiable?

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37712/29544

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc modified in PR(s): Modifying the AlcaPCCIntegrator for processing concurrent lumiblocks #37538

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37712/29544/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37712/29544/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

e.g. 1020?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37712/29545

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc modified in PR(s): Modifying the AlcaPCCIntegrator for processing concurrent lumiblocks #37538

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Calibration/LumiAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

e.g. 1020?

Yes, I added that to the wf-s

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2b54c/24279/summary.html
COMMIT: 067f72d
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37712/24279/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.2 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /pool/condor/dir_287101/jenkins/workspace/compare-root-files-short-matrix/data/PR-b2b54c/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA
• /pool/condor/dir_287101/jenkins/workspace/compare-root-files-short-matrix/data/PR-b2b54c/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 212 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2b54c/24279/runTheMatrix-results/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA/ runs
• https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2b54c/24279/runTheMatrix-results/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP/. runs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

thanks @mmusich Please also backport to 12_3_X or include it in #37671

[tvami]

@qliphy to make things quicker, I submitted the backport: #37720