[L1] CSCTF fix issue with writing beyond array boundaries #37707
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37707/29535
|
|
A new Pull Request was created by @cecilecaillol for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-818cf9/24261/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
|
+l1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| status.link_status[lct[0].spInput()] |= (1 << lct[0].receiver_status_frame1()) | | ||
| (1 << lct[0].receiver_status_frame2()) | | ||
| ((lct[0].aligment_fifo() ? 1 : 0) << 4); | ||
| status.link_status[lct[0].spInput() - 1] |= (1 << lct[0].receiver_status_frame1()) | |
There was a problem hiding this comment.
It is always dangerous to make differences of unsigned quantities.
On the other hand, CSCSP_MEblock::spInput_ is defined as being in the range [1-15], and the same difference is already used later on in this very same code in:
and
I assume therefore that is also safe to have the same difference computed here
|
+1 |
PR description:
Addressing issue #37687. spInput returns a number between 1 and 15.