-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.2.X] fix the cms EDModule type of GenParticleMatchMerger
#37653
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bug-fix |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecfee3/24122/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
Since CMSSW_12_2_X_2022-04-22-2300 some of the HLT validation tests fail with error message:
The only PR integrated is this one, @mmusich could you please have a look? The workflow is:
|
@Martin-Grunewald this has absolutely nothing to do with this PR. |
@Martin-Grunewald this is due to the change of the underlying boost version for |
So I assume with the new boost in 12_3 someone has written a new record now also consumed within 12_2 ? |
What is happening here is that you are trying to read a payload written with boost 1.78 (so presumably written only recently) with a version that only supports up to 1.75. |
OK, thanks. Moved the discussion here: |
backport of #37613
PR description:
It appears that
CollectionAdder
cmssw/CommonTools/UtilAlgos/interface/CollectionAdder.h
Line 17 in 837fd56
which is the underlying module type of
cmssw/PhysicsTools/HepMCCandAlgos/plugins/GenParticleMatchMerger.cc
Line 4 in 6d2f660
is an
EDProducer
, but it was declared in the configuration as anEDFilter
:cmssw/SimTracker/TrackAssociation/python/allTrackMCMatch_cfi.py
Line 3 in 837fd56
leading to runtime errors of the type:
this is trivially fixed here.
In addition in commit f68a4df, I take care of some other mismatched types in the configuration.
The parameter
associator
ofMCTrackMatcher
should be acms.string
and not acms.InputTag
:cmssw/SimTracker/TrackAssociation/plugins/MCTrackMatcher.cc
Line 44 in 9583b99
Finally in the same commit, the value of the variable
associator
inTracker/TrackAssociation/python/trackMCMatch_cfi.py
is corrected such that it istrackAssociatorByHits
and notTrackAssociatorByHits
PR validation:
Private scripts.
if this PR is a backport please specify the original PR and why you need to backport that PR:
verbatim backport of #37613.