Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AlCaRecoMatrix for Run 3 #37590

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR updates the AlCaRecoMatrix to be used for Run 3:

  • Moved the AlCaRecoMatrix[2018|2017|2016|2015] to AlCa/doc/pastAlCaRecoMatrix.py since they are not really used anywhere in CMSSW, but only kept for documentation purposes
  • Updated the AlCaRecoMatrix to the values for Run 3, as described in the AlCaRecoMatrix twiki for 2022

PR validation:

Tested with:
runTheMatrix.py -l limited -j 16 --ibeos -t 4

Backport:

Not a backport but a backport to 12_3_X will be provided soon.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37590/29350

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce0d81/23963/summary.html
COMMIT: 75a9c92
CMSSW: CMSSW_12_4_X_2022-04-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37590/23963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593159
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3593122
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.051000000000000004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.027 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.027 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37590/29477

@tvami
Copy link
Contributor

tvami commented Apr 25, 2022

unhold

@tvami
Copy link
Contributor

tvami commented Apr 25, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37590/29491

@cmsbuild
Copy link
Contributor

Pull request #37590 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce0d81/24198/summary.html
COMMIT: 2a7f2df
CMSSW: CMSSW_12_4_X_2022-04-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37590/24198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_31152/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce0d81/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 29 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695403
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.117 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.059 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Apr 26, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Adjustments seem settled down now...

@makortel
Copy link
Contributor

This PR might have caused 1001.2 step2 to fail with

----- Begin Fatal Exception 26-Apr-2022 13:15:01 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 305064 lumi: 2 event: 1783800 stream: 0
   [1] Running path 'pathALCARECOAlCaPCCRandom'
   [2] Calling method for module AlcaPCCIntegrator/'alcaPCCIntegratorRandom'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: reco::PixelClusterCountsInEvent
Looking for module label: hltAlcaPixelClusterCounts
Looking for productInstanceName: alcaPCCEvent

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

see #37685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants