-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update TopMuEG skim to latest HLT paths in BTV #37574
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37574/29323
|
A new Pull Request was created by @AnnikaStein (Annika Stein) for master. It involves the following packages:
@cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db29cb/23929/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Nice work on updating the skim. Could all the "keep" statements in the test fragment be reduced to just a few lines by using more inclusive wildcards or this is not possible? |
Thank you for the feedback. It should indeed be possible to reduce some of the lines by manually combining them with wildcards. However, this test fragment is just the result of using the TopMuEGPath as part of DPG skims which automatically produces this list of keep and drop statements. Maybe it would then make sense to keep it as it is, allowing comparisons with related test configurations of other DPG skims. If I understand correctly, this is a fundamental difference with respect to PAG skims, where the EventContent / keep / drop is defined individually per test configuration, because the use case is different. Should we decide to still manually adapt the keep / drop statements explicitly to our needs and simplifying or reducing them, this would also be an opportunity to check with all experts involved which branches are of interest. (Tagger outputs? Tagger inputs? Different generations of taggers?) |
Thanks for the explanations! I think this is fine, unless @cms-sw/orp-l2 have other suggestions. |
fine with me. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
skims -s SKIM:TopMuEG --mc --dasquery=file dataset=/RelValTTbar_14TeV/CMSSW_12_1_0_pre2-PU_121X_mcRun3_2021_realistic_v1-v1/GEN-SIM-RECO -n 100 --conditions auto:phase1_2021_realistic --eventcontent=FEVTDEBUGHLT --datatier=RAW-RECO --python_filename=test_TopMuEG_SKIM.py --processName=SKIMTopMuEG --no_exec --era=Run3
if this PR is a backport please specify the original PR and why you need to backport that PR:
@johnalison @soureek