Run4-hgx306 Backport the bugfix to HGCal geometry from the PR's 37330 and 37460

[bsunanda]

PR description:

Backport the bugfix to HGCal geometry from the PR's 37330 and 37460 which calculates the corners of the cells in the rotated layers correctly

PR validation:

Use the runTheMatrix test workflows and some code in the test area of Geometry/HGCa;Geometry

.#### if this PR is a backport please specify the original PR and why you need to backport that PR:

The PR #37330 is merged with the master. The PR #37460 only takes care of comments suggested by Andreas while merging #37330

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_3_X.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• Geometry/HGCalGeometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Phase2-hg302 Bug fix for the corners and replacing cout with message logger services #37330

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b1689/23660/summary.html
COMMIT: 250803c
CMSSW: CMSSW_12_3_X_2022-04-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37466/23660/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697345
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[srimanob]

+Upgrade

This is a backport PR. It should be useful for Phase-2 production for L1-HLT.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #37330

[perrotta]

This addition is not needed, unless you also backport #37374

[bsunanda]

The extra include is removed

[perrotta]

@bsunanda is it not needed in the backport the test code and scripts which were merged with #37330?

[bsunanda]

@cmsbuild Please test

[cmsbuild]

Pull request #37466 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b1689/23728/summary.html
COMMIT: 7aa146a
CMSSW: CMSSW_12_3_X_2022-04-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37466/23728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697351
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[perrotta]

@srimanob you already signed this once, I think latest additions (a couple of test files, as in the master) should be rather innocuos: we are waiting anyhow for your further signature before merging this backport in 12_3_X

[srimanob]

+Upgrade

This is a backport PR which should be useful for comping production of Phase-2.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1