Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary inclusions from DataFormats/L1Trigger that would cause a recursive referencing of the BuildFiles #37368

Closed
wants to merge 1 commit into from

Conversation

perrotta
Copy link
Contributor

PR description:

Possibile fix for the issue reported in #37287 (comment)

PR validation:

It builds

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37368/29022

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • DataFormats/L1Trigger (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @eyigitba, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

The correct fix was implemented by @smuzaffar in cms-sw/cmsdist#7725

@perrotta perrotta closed this Mar 27, 2022
@perrotta perrotta deleted the removeUnnecessaryInclusions branch March 27, 2022 17:46
@perrotta perrotta restored the removeUnnecessaryInclusions branch April 6, 2022 08:24
@perrotta perrotta deleted the removeUnnecessaryInclusions branch April 6, 2022 09:55
@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

perrotta commented Apr 6, 2022

+l1

Thank you Cecile.
But the actual PR that needs your signature is now #37478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants