[12.2.X] Change to SiStripCluster DataFormat: use auto for return types

[mmusich]

PR description:

Verbatim backport of #36852, needed for Run-3 POG preparatory MC running in CMSSW_12_2_X.
See issues in production at unified.

PR validation:

How to reproduce:

• use PSet from unified, and run it in CMSSW_12_2_1 (it is also available at this gist of mine).
• using this commit it should not fail anymore.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #36852

FYI: @kskovpen

[mmusich]

type bug-fix

[mmusich]

urgent

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

• DataFormats/SiStripCluster (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @swertz, @pieterdavid, @robervalwalsh, @rovere, @VinInn, @alesaggio, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Change to SiStripCluster DataFormat: use auto for return types #36852

[mmusich]

@cmsbuild, please test

[mmusich]

backport of #36852

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90fc8f/23356/summary.html
COMMIT: dff9a86
CMSSW: CMSSW_12_2_X_2022-03-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37334/23356/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testCalibrationTkAlCaRecoProducers had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251287
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[mmusich]

Looks like this:

---> test testCalibrationTkAlCaRecoProducers had ERRORS

is failing also in IB unit tests: https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_2_X_2022-03-24-1100/unitTestLogs/Calibration/TkAlCaRecoProducers#/156

[qliphy]

please test
testCalibrationTkAlCaRecoProducers unit error is already in IB and not related to this PR.
There is another error from RelVals-INPUT which looks like temporary, to check again here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90fc8f/23374/summary.html
COMMIT: dff9a86
CMSSW: CMSSW_12_2_X_2022-03-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37334/23374/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testCalibrationTkAlCaRecoProducers had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3251287
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

It seems to me that the unit test error follows temporarily the merging of #37212 in 12_2
I have posted a comment in that PR thread to get some possible clue.

[mmusich]

please test with cms-sw/cmsdist#7718

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90fc8f/23381/summary.html
COMMIT: dff9a86
CMSSW: CMSSW_12_2_X_2022-03-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37334/23381/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3251324
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3251293
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

Please @cms-sw/reconstruction-l2 let us know what do you think about this backport.
It is modifying a DataFormat in a closed production release, but

• we have real issues in production
• this is a technical PR which does not affect the reconstruction (a part for the previously failing events)

[clacaputo]

Hi @perrotta , I'm checking it right now, following the instruction provided by @mmusich

[mmusich]

@clacaputo as a warning, the issue appears randomly. The recipe I provided might (or might not) yield the segmentation fault, e.g. I could not reproduce it multiple times.

[qliphy]

kindly ping @cms-sw/reconstruction-l2
A new 12_2_X release is pending on this PR.

[clacaputo]

+reconstruction

• 36669 bp
• no reco changes expected or observed
• tested locally

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1