Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the refactoring of the PropagateToMuon class and add the propagating to some HLT filters #37299

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

JanFSchulte
Copy link
Contributor

Backport of #37180 to 12_3_X as the improved HLT performance is needed to be available in this release for first data taking as discussed in the PR for the main branch.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2022

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_12_3_X.

It involves the following packages:

  • DQMOffline/L1Trigger (dqm, l1)
  • HLTrigger/Muon (hlt)
  • L1Trigger/L1TNtuples (l1)
  • MuonAnalysis/MuonAssociators (analysis)

@Martin-Grunewald, @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @santocch, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @Fedespring, @kreczko, @calderona, @silviodonato, @abbiendi, @jhgoh, @eyigitba, @Martin-Grunewald, @bellan, @HuguesBrun, @CeliaFernandez, @thomreis, @dinyar, @battibass, @missirol, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

backport of #37180

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e737a0/23275/summary.html
COMMIT: 2703878
CMSSW: CMSSW_12_3_X_2022-03-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37299/23275/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695080
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@jfernan2
Copy link
Contributor

+1
Changes in line with #37180

@cecilecaillol
Copy link
Contributor

+l1

@missirol
Copy link
Contributor

+hlt

@perrotta
Copy link
Contributor

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 3641606 into cms-sw:CMSSW_12_3_X Mar 23, 2022
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants