Introduce generalized abstraction for Strip Payload Inspector

[mmusich]

PR description:

The purpose of this PR is to introduce a generalized abstraction for Strip Payload inspector SiStripCondObjectRepresent and use it to make detailed comparison and correlation plots for the Strip payload inspector.

PR validation:

Relies on augmented unit tests and extended private validation.
Example of plots obtainable with the new additions.

• Strip Noise:

• Strip Pedestals:

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28892

• This PR adds an extra 192KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/SiStripPlugins (db)
• CondFormats/SiStripObjects (db, alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@erikbutz, @tocheng, @VinInn, @mmusich, @threus, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadc83/23190/summary.html
COMMIT: 92ce12f
CMSSW: CMSSW_12_4_X_2022-03-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37265/23190/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28894

• This PR adds an extra 180KB to repository

[cmsbuild]

Pull request #37265 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadc83/23195/summary.html
COMMIT: 9996be4
CMSSW: CMSSW_12_4_X_2022-03-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37265/23195/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 22
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695332
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37265/28937

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #37265 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[perrotta]

I squashed the commits into a single one, though as long as the commit descriptions are pertinent and do not spoil the repository history, I don't see why a long list of commits is bad...

Ciao Marco.
Would every commit act independently on a single (set of) file(s) there would be indeed probably no need to squash them. However, most of the time, in the PRs we have quite a lot of commits that modify in sequence the very same file. Try to imagine a future developer (or even a "bugfixer") who has to dig into that whole bunch of modifications that may overwrite each other, in order to find hints for the specific code change she/he is interested in: it is much easier to be able to inspect THE modifications applied by a given PR to a given file all at once.

[mmusich]

Try to imagine a future developer (or even a "bugfixer") who has to dig into that whole bunch of modifications that may overwrite each other, in order to find hints for the specific code change she/he is interested in: it is much easier to be able to inspect THE modifications applied by a given PR to a given file all at once.

Ciao Andrea,
thanks for the clarification.
I won't argue further as in fact I already squashed the commits, but this is what I meant as "do not spoil the repository history". Even if subsequent commits touch the same files as long as they act on separate, logically disjointed, portions of the code I would maintain longer commit lists are actually advantageous for debugging purposes (I admit it's difficult to code that way when developing, and breaking down code changes in optimal chunks requires some conscious effort and that was not done - generally speaking - here). My comment was prompted by the observation about requests of squashing commits in several other PRs and so, if that's deemed more convenient for review purposes I can always stick to the preferred policy.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadc83/23288/summary.html
COMMIT: d4b6d65
CMSSW: CMSSW_12_4_X_2022-03-22-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37265/23288/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
534.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cadc83/39434.911_TTbar_14TeV+2026D88_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 51793
• DQMHistoTests: Total nulls: 45
• DQMHistoTests: Total successes: 3643790
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

• differences are not related to this PR and already reported in issues Comparison failed for tests of wf 39434.911 #37315 and Spurious failing comparisons entries in PR tests for MuonCSCDigisV/CSCDigiTask/CLCT #37268

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1