-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from int64_t
to uint64_t
to avoid bit shifting negative numbers (UB in C++)
#37252
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37252/28857
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e8cea/23139/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
(running UBSAN offline...) |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In partial response to #35036 (comment).
Followed suggestion at #35036 (comment) (e.g.
xx
,yy
,track_eta
andtrack_phi
can be negative, hence when casted toint64_t
- and preserving the sign, the bit shift can lead to undefined behaviour), so changed the cast fromint64_t
touint64_t
.This solution has also been privately discussed with the original author @vberta
PR validation:
cmssw
compiles, also run a typical battery of ad-hoc relvals withseedingDeepCore
enabled:runTheMatrix.py --what upgrade -l 11634.17,11723.17,11834.17,11923.17 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A