Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTDeDxFilter: prevent variable length array bound evaluates to non-positive value #37229

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 13, 2022

PR description:

In partial response to #35036 (comment)

PR validation:

cmssw compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37229/28827

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • RecoTracker/DeDx (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 13, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a89a85/23078/summary.html
COMMIT: 5755ec1
CMSSW: CMSSW_12_4_X_2022-03-13-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37229/23078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695119
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Mar 14, 2022

@cmsbuild, please test for CMSSW_12_4_UBSAN_X_2022-03-11-1100

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

@jpata doesn't look #37229 (comment) had any effect.
Please clarify the intentions.

@jpata
Copy link
Contributor

jpata commented Mar 15, 2022

indeed... not sure why the bot didn't pick this up. I was running UBSAN offline now.

@jpata
Copy link
Contributor

jpata commented Mar 15, 2022

+reconstruction

  • UBSAN error at RecoTracker/DeDx/plugins/HLTDeDxFilter.cc:119:35 disappears
  • no reco differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a314daf into cms-sw:master Mar 15, 2022
@mmusich mmusich deleted the RecoTrackerDeEx_makeUBSANhappy branch March 15, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants