Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autoCond.py to include GTs with fixed L1 Menu for Run3 #37171

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Mar 8, 2022

PR description:

This PR is to include two new GTs to autoCond.py: run3_hlt_relval and run3_data_relval. These GTs will be included in relval workflows for Run3 with fixed L1T Menu and were requested by TSG. They are based on the HLT and offline data GTs with a difference of the L1Menu tags as can be seen below.

The relval workflows to use these GTs will be added at a later step.

The difference in the Run3 relval GTs wrt the HLT and offline Queues:

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_relval_v1/123X_dataRun3_HLT_v5

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_relval_v1/123X_dataRun3_v4

FYI: @Martin-Grunewald

PR validation:

The GTs included in autoCond are not in any relval workflow to be tested yet.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N.A.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37171/28736

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Mar 8, 2022

please test

@tvami
Copy link
Contributor

tvami commented Mar 8, 2022

urgent

  • we'd like this in pre6

@cmsbuild cmsbuild added the urgent label Mar 8, 2022
@tvami
Copy link
Contributor

tvami commented Mar 8, 2022

+alca

  • in the current version of CMSSW nothing consumes these autoCond keys (that will be the next step), i.e. the tests are not testing anything

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7a5c32/22933/summary.html
COMMIT: 4461d50
CMSSW: CMSSW_12_3_X_2022-03-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37171/22933/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3985573
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3985549
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

@cms-sw/orp-l2 just FYI (since it was discussed in ORP meeting), this was signed already before the tests started, but now we have the tests results that prove this PR is fine.

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants