Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtSpecFilter of M9 and add DD4hep wf for D77 #37142

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 4, 2022

PR description:

This PR follows #37078, to fix M9 geometry. In case we don't move to D88 in the near future, we plan to use D77 to vallidate DDD-vs-DD4hep of Phase-2. No change is expected for existing DDD wf (as see in the #37078).

PR validation:

Test with wf 35034.911 (TTbar NoPU D77 DD4hep XML)

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no need of backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37142/28678

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin can you please review it and eventually sign? Thanks.
@missirol, @makortel, @vargasa, @kpedro88, @Martin-Grunewald, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2022

test parameters:

  • workflow = 35034.911

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05d582/22840/summary.html
COMMIT: 61b66d5
CMSSW: CMSSW_12_3_X_2022-03-04-0800/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37142/22840/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-05d582/35034.911_TTbar_14TeV+2026D77_DD4hep+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987741
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3987717
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Mar 5, 2022

+Upgrade

This PR follows the discussion with @civanch @cvuosalo to fix dtSpecFilter on M9. This will allow us to validate Phase-2 DD4hep on D77 in case we will need to stay with it a bit longer.

The PR test run fine with no change is expected on current DDD workflow. The new D77 DD4hep (35034.911) wf runs until finish.

@srimanob
Copy link
Contributor Author

srimanob commented Mar 7, 2022

Urgent

Need it for 12_3_0_pre6, to allow DD4hep Phase-2 validation using D77.

@cmsbuild cmsbuild added the urgent label Mar 7, 2022
@kskovpen
Copy link
Contributor

kskovpen commented Mar 7, 2022

+pdmv

@cvuosalo
Copy link
Contributor

cvuosalo commented Mar 7, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 8, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants