-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dtSpecFilter of M9 and add DD4hep wf for D77 #37142
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37142/28678
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages:
@civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05d582/22840/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+Upgrade This PR follows the discussion with @civanch @cvuosalo to fix dtSpecFilter on M9. This will allow us to validate Phase-2 DD4hep on D77 in case we will need to stay with it a bit longer. The PR test run fine with no change is expected on current DDD workflow. The new D77 DD4hep (35034.911) wf runs until finish. |
Urgent Need it for 12_3_0_pre6, to allow DD4hep Phase-2 validation using D77. |
+pdmv |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR follows #37078, to fix M9 geometry. In case we don't move to D88 in the near future, we plan to use D77 to vallidate DDD-vs-DD4hep of Phase-2. No change is expected for existing DDD wf (as see in the #37078).
PR validation:
Test with wf 35034.911 (TTbar NoPU D77 DD4hep XML)
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport and no need of backport.