-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134
Merged
Merged
Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134
Changes from 35 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f3fee7c
One merged commit
ssrothman 32c5854
Fix ES data getting to be compliant with newer CMSSW
ssrothman 2da29a3
Added test
ssrothman 616831b
code-format and code-checks
ssrothman 3cdd06c
Code-format (again??)
ssrothman 0bf9e99
Made test shorter
ssrothman da3c714
Fixed model name
ssrothman 5af31a1
Not sure what's going on here tbh...
ssrothman fe1ee8e
Revert "Not sure what's going on here tbh..."
ssrothman c65a63d
Rename customisation function appropriately
ssrothman e36b116
Updated test config to call correct customisation function name
ssrothman 26dfae6
Fixed customisation function to be compatible with cmsDriver
ssrothman 30e291e
Almost working.....
ssrothman 82ced8d
Kevin found the problem :D
ssrothman 2f80e2f
Removed test
ssrothman d357aa7
UserFloat functionality
ssrothman 9556a83
Fixed fatal typos
ssrothman 2637202
No reason to touch runtests.sh
ssrothman 1a5de2f
Pointers..
ssrothman f994140
Clean up DRNCorrectionProducerT
ssrothman e5db2ac
Error fixing...
ssrothman ec15ac7
Should compile now
ssrothman cc93d65
empty commit to get cms bot to rerun code checks
ssrothman c3927d0
Code-format
ssrothman 722602b
Don't need ES Handles
ssrothman c658fab
No longer pointers
ssrothman 509d4a1
Typo fix
ssrothman 84c52f2
Adding process modifier
ssrothman 0e55eb0
Typo fix
ssrothman c99da3c
userFloats by default
ssrothman 8a69393
RelVal use modifier
ssrothman fa89ab1
Replace p4 matching
ssrothman bb7c727
Clean up after removing p4 comparison
ssrothman bccd830
Merge branch 'noHandle' into photon_rebase2
ssrothman 8c0bd7c
Code-format
ssrothman 1ab9afd
photonDRN modifier now includes enableSonicTriton
ssrothman fc9c472
use fillDescriptions defaults for recHits
ssrothman 78558dc
shared memory on
ssrothman 7ecb877
test clone...
ssrothman a8702fa
Revert "test clone..."
ssrothman 5977c4b
Cloning fillDescriptions config
ssrothman c8484f9
Same for electrons
ssrothman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
#modifier to enable DRN energy regression for photons | ||
|
||
photonDRN = cms.Modifier() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
PhysicsTools/PatAlgos/python/slimming/patElectronDRNCorrector_cfi.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
patElectronsDRN = cms.EDProducer("PatElectronDRNCorrectionProducer", | ||
particleSource = cms.InputTag("selectedPatElectrons"), | ||
rhoName = cms.InputTag("fixedGridRhoFastjetAll"), | ||
reducedEcalRecHitsEB = cms.InputTag("reducedEcalRecHitsEB"), | ||
reducedEcalRecHitsEE = cms.InputTag("reducedEcalRecHitsEE"), | ||
reducedEcalRecHitsES = cms.InputTag("reducedEcalRecHitsES"), | ||
|
||
Client = cms.PSet( | ||
mode = cms.string("Async"), | ||
modelName = cms.string("electronObjectEnsemble"), | ||
modelConfigPath = cms.FileInPath("RecoEgamma/EgammaElectronProducers/data/models/electronObjectEnsemble/config.pbtxt"), | ||
ssrothman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
allowedTries = cms.untracked.uint32(1), | ||
timeout = cms.untracked.uint32(10), | ||
useSharedMemory = cms.untracked.bool(False), | ||
) | ||
) |
18 changes: 18 additions & 0 deletions
18
PhysicsTools/PatAlgos/python/slimming/patPhotonDRNCorrector_cfi.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
patPhotonsDRN = cms.EDProducer("PatPhotonDRNCorrectionProducer", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment here regarding cloning the producer config |
||
particleSource = cms.InputTag("selectedPatPhotons"), | ||
rhoName = cms.InputTag("fixedGridRhoFastjetAll"), | ||
reducedEcalRecHitsEB = cms.InputTag("reducedEcalRecHitsEB"), | ||
reducedEcalRecHitsEE = cms.InputTag("reducedEcalRecHitsEE"), | ||
reducedEcalRecHitsES = cms.InputTag("reducedEcalRecHitsES"), | ||
|
||
Client = cms.PSet( | ||
mode = cms.string("Async"), | ||
modelName = cms.string("photonObjectEnsemble"), | ||
modelConfigPath = cms.FileInPath("RecoEgamma/EgammaPhotonProducers/data/models/photonObjectEnsemble/config.pbtxt"), | ||
ssrothman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
allowedTries = cms.untracked.uint32(1), | ||
timeout = cms.untracked.uint32(10), | ||
useSharedMemory = cms.untracked.bool(False), | ||
) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to clone the existing config from the one provided by fillDescriptions (I recall a similar comment on the previous DRN PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you just mean to use the fillDescriptions defaults for more parameters, or is there something more I should do here? I have updated it to use default values for the RecHit collections; should I add more defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean using
.clone
to avoid specifying the config options (and the types) that are already known.3cb2459#diff-2d4d8dba5a6cd14974d0d42a9896706879c369b9ca833acca0f8e9f1883b1500R3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about how to do this. If I try to import
RecoEgamma.EgammaTools.PatPhotonDRNCorrectionProducer_cfi
I get aModuleNotFoundError
. Where is this default config produced by fillDescriptions()? How (if at all) does it interact with class templating?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your working area, you can look at
$CMSSW_BASE/cfipython
to find the default configs.To ensure distinct cfi files are generated for different instances of the same class template, see this example:
cmssw/HeterogeneousCore/SonicTriton/test/TritonGraphModules.cc
Lines 107 to 108 in f6c204b