Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
| from PhysicsTools.PatAlgos.tools.helpers import getPatAlgosToolsTask | ||
|
|
||
| def enableDRN(process): | ||
| process.load("PhysicsTools.PatAlgos.slimming.patPhotonDRNCorrector_cfi") | ||
| process.DRNTask = cms.Task(process.patPhotonsDRN) | ||
| process.schedule.associate(process.DRNTask) | ||
| process.slimmedPhotons.modifierConfig.modifications.append( | ||
| cms.PSet( modifierName = cms.string("EGRegressionModifierDRN"), | ||
| patPhotons = cms.PSet( | ||
| source = cms.InputTag('selectedPatPhotons'), | ||
| correctionsSource = cms.InputTag('patPhotonsDRN') | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| return process |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| patElectronsDRN = cms.EDProducer("PatElectronDRNCorrectionProducer", | ||
| particleSource = cms.InputTag("selectedPatElectrons"), | ||
| rhoName = cms.InputTag("fixedGridRhoFastjetAll"), | ||
| reducedEcalRecHitsEB = cms.InputTag("reducedEcalRecHitsEB"), | ||
| reducedEcalRecHitsEE = cms.InputTag("reducedEcalRecHitsEE"), | ||
| reducedEcalRecHitsES = cms.InputTag("reducedEcalRecHitsES"), | ||
|
|
||
| Client = cms.PSet( | ||
| mode = cms.string("Async"), | ||
| modelName = cms.string("electronObjectEnsemble"), | ||
| modelConfigPath = cms.FileInPath("RecoEgamma/EgammaElectronProducers/data/models/electronObjectEnsemble/config.pbtxt"), | ||
ssrothman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| allowedTries = cms.untracked.uint32(1), | ||
| timeout = cms.untracked.uint32(10), | ||
| useSharedMemory = cms.untracked.bool(False), | ||
| verbose = cms.untracked.bool(True) | ||
|
There was a problem hiding this comment. is verbose=True intentional? I still have the feeling that each physics model having their own version of technical Triton/Sonic config values (e.g. timeout, shared mem, retries) is not optimal. There was a problem hiding this comment. In general, this is unavoidable. Different models have different execution times, therefore they cannot all share a single timeout. Some models might need to have shared memory disabled for a variety of reasons, etc. However, I agree that verbose=True should be disabled in the PR (it's mainly for testing/profiling). |
||
| ) | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| patPhotonsDRN = cms.EDProducer("PatPhotonDRNCorrectionProducer", | ||
|
There was a problem hiding this comment. same comment here regarding cloning the producer config |
||
| particleSource = cms.InputTag("selectedPatPhotons"), | ||
| rhoName = cms.InputTag("fixedGridRhoFastjetAll"), | ||
| reducedEcalRecHitsEB = cms.InputTag("reducedEcalRecHitsEB"), | ||
| reducedEcalRecHitsEE = cms.InputTag("reducedEcalRecHitsEE"), | ||
| reducedEcalRecHitsES = cms.InputTag("reducedEcalRecHitsES"), | ||
|
|
||
| Client = cms.PSet( | ||
| mode = cms.string("Async"), | ||
| modelName = cms.string("photonObjectBothEnsemble"), | ||
| modelConfigPath = cms.FileInPath("RecoEgamma/EgammaPhotonProducers/data/models/photonObjectEnsemble/config.pbtxt"), | ||
ssrothman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| allowedTries = cms.untracked.uint32(1), | ||
| timeout = cms.untracked.uint32(10), | ||
| useSharedMemory = cms.untracked.bool(False), | ||
| verbose = cms.untracked.bool(True) | ||
|
|
||
| ) | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to clone the existing config from the one provided by fillDescriptions (I recall a similar comment on the previous DRN PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you just mean to use the fillDescriptions defaults for more parameters, or is there something more I should do here? I have updated it to use default values for the RecHit collections; should I add more defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean using
.cloneto avoid specifying the config options (and the types) that are already known.3cb2459#diff-2d4d8dba5a6cd14974d0d42a9896706879c369b9ca833acca0f8e9f1883b1500R3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about how to do this. If I try to import
RecoEgamma.EgammaTools.PatPhotonDRNCorrectionProducer_cfiI get aModuleNotFoundError. Where is this default config produced by fillDescriptions()? How (if at all) does it interact with class templating?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your working area, you can look at
$CMSSW_BASE/cfipythonto find the default configs.To ensure distinct cfi files are generated for different instances of the same class template, see this example:
cmssw/HeterogeneousCore/SonicTriton/test/TritonGraphModules.cc
Lines 107 to 108 in f6c204b