Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL DQM - Add WF .513 for ECAL GPU vs. CPU validation #37123

Merged
merged 5 commits into from
Mar 9, 2022
+54 −34
Merged

ECAL DQM - Add WF .513 for ECAL GPU vs. CPU validation #37123

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
adbbc2c
Add WF .515 for ECAL GPU vs. CPU validation.
thomreis Mar 2, 2022
0a4399f
Move WF to .513.
thomreis Mar 3, 2022
83b357f
Add accelerators cmsDriver option to request an nvidia GPU.
thomreis Mar 3, 2022
6553266
Fix python error.
thomreis Mar 3, 2022
f9271b0
Add .513 WFs to relval_gpu.
thomreis Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Configuration/PyReleaseValidation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,17 @@ The offsets currently in use are:
* 0.5: Pixel tracking only + 0.1
* 0.501: Patatrack, pixel only quadruplets, on CPU
* 0.502: Patatrack, pixel only quadruplets, with automatic offload to GPU if available
* 0.504: Patatrack, pixel only quadruplets, GPU profiling
* 0.505: Patatrack, pixel only triplets, on CPU
* 0.506: Patatrack, pixel only triplets, with automatic offload to GPU if available
* 0.508: Patatrack, pixel only triplets, GPU profiling
* 0.511: Patatrack, ECAL only, on CPU
* 0.512: Patatrack, ECAL only, with automatic offload to GPU if available
* 0.513: Patatrack, ECAL only, GPU vs. CPU validation
* 0.514: Patatrack, ECAL only, GPU profiling
* 0.521: Patatrack, HCAL only, on CPU
* 0.522: Patatrack, HCAL only, with automatic offload to GPU if available
* 0.524: Patatrack, HCAL only, GPU profiling
* 0.591: Patatrack, full reco with pixel quadruplets, on CPU
* 0.592: Patatrack, full reco with pixel quadruplets, with automatic offload to GPU if available
* 0.595: Patatrack, full reco with pixel triplets, on CPU
Expand Down
17 changes: 16 additions & 1 deletion Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,22 @@ def setup_(self, step, stepName, stepDict, k, properties):
offset = 0.512,
)

# add here a .513 workflow for GPU vs CPU validation
upgradeWFs['PatatrackECALOnlyGPUValidation'] = PatatrackWorkflow(
digi = {
'--accelerators': 'gpu-nvidia',
'--procModifiers': 'gpu,gpuValidationEcal'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuValidationEcal is not needed here, because I don't think we run any validation in the DIGI step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not.

},
reco = {
'-s': 'RAW2DIGI:RawToDigi_ecalOnly,RECO:reconstruction_ecalOnly,VALIDATION:@ecalOnlyValidation,DQM:@ecalOnly',
'--accelerators': 'gpu-nvidia',
'--procModifiers': 'gpu,gpuValidationEcal'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuValidationEcal could be more generally gpuValidation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one would also include the HCAL validation modifier. And maybe others in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the idea.
Like the gpu modifier can enable the use of GPUs in the various parts of the reconstruction, the gpuValidation modifier should enable the GPU validation in all the parts of the reconstruction that run and support it.

Then, since this workflow only runs the ECAL reconstruction and validation, only those two are customised.

},
harvest = {
'-s': 'HARVESTING:@ecalOnlyValidation+@ecal'
},
suffix = 'Patatrack_ECALOnlyGPU_Validation',
offset = 0.513,
)

upgradeWFs['PatatrackECALOnlyGPUProfiling'] = PatatrackWorkflow(
digi = {
Expand Down
2 changes: 1 addition & 1 deletion DQM/EcalMonitorTasks/python/EcalMonitorTask_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
from Configuration.ProcessModifiers.gpuValidationEcal_cff import gpuValidationEcal
from DQM.EcalMonitorTasks.ecalGpuTask_cfi import ecalGpuTask

gpuValidationEcal.toModify(ecalGpuTask.params, runGpuTask = cms.untracked.bool(True))
gpuValidationEcal.toModify(ecalGpuTask.params, runGpuTask = True)
gpuValidationEcal.toModify(ecalMonitorTask.workers, func = lambda workers: workers.append("GpuTask"))
gpuValidationEcal.toModify(ecalMonitorTask, workerParameters = dict(GpuTask = ecalGpuTask))