Remove dead assignments and simplify HLTmumutkFilter

[perrotta]

PR description:

As the title says
Dead assignments were reported by the static analyzer

PR validation:

It builds
No changes expected

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36977/28347

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @silviodonato, @Martin-Grunewald, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71eb5f/22448/summary.html
COMMIT: c13d623
CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36977/22448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3764435
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3764399
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[missirol]

Hi @perrotta , thanks for the PR. Just for my education, where do I find the static-analyzer reports you mentioned?

[perrotta]

Hi @perrotta , thanks for the PR. Just for my education, where do I find the static-analyzer reports you mentioned?

I hit it while reviewing one of the latest PRs that touched this package, I don't remember by heart which one now...
Anyhow, all SA reports for all packages can be inspected from the IB pages, e.g. https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_3_X

[missirol]

Thanks, found it:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d72fb/22374/llvm-analysis/runStaticChecks.log

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-11-2300/src/HLTrigger/btau/plugins/HLTmumutkFilter.cc:186:9: warning: Value stored to 'track1Matched' is never read [deadcode.DeadStores]
        track1Matched = true;
        ^               ~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-11-2300/src/HLTrigger/btau/plugins/HLTmumutkFilter.cc:192:9: warning: Value stored to 'track2Matched' is never read [deadcode.DeadStores]
        track2Matched = true;
        ^               ~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-11-2300/src/HLTrigger/btau/plugins/HLTmumutkFilter.cc:198:9: warning: Value stored to 'track3Matched' is never read [deadcode.DeadStores]
        track3Matched = true;
        ^               ~~~~
3 warnings generated.

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1