-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backporting gen filter to CMSSW_10_6_X #36955
backporting gen filter to CMSSW_10_6_X #36955
Conversation
A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for CMSSW_10_6_X. It involves the following packages:
@SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @GurpreetSinghChahal, @Saptaparna, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7fedb/22406/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #27791 modifying EmbeddingHepMCFilter:
These modifications are needed so that we can use this filter for a UL MC request.
This filter was already backported and used successfully for pre-UL MC campaigns, but it is needed now for UL MC requests requiring a backport to CMSSW_10_6_X as well.
The filter reduces the required statistics for our samples by a factor of 4 - without this filter the size of the sample required would be unfeasible to produce.
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
The original PR: #27791