Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting gen filter to CMSSW_10_6_X #36955

Merged

Conversation

danielwinterbottom
Copy link

PR description:

Backport of #27791 modifying EmbeddingHepMCFilter:

  • Setting the boson PDGID under option so that the filter can be used for Higgs events
  • Adding booleans to make sure the correct tau decay types are identified in cases where there are additional FSR photons
    These modifications are needed so that we can use this filter for a UL MC request.
    This filter was already backported and used successfully for pre-UL MC campaigns, but it is needed now for UL MC requests requiring a backport to CMSSW_10_6_X as well.
    The filter reduces the required statistics for our samples by a factor of 4 - without this filter the size of the sample required would be unfeasible to produce.

PR validation:

  • Checked that the modifications compile in CMSSW_10_6_29_patch1
  • These modifications were already tested and used successfully used for several MC productions for pre-UL samples

if this PR is a backport please specify the original PR and why you need to backport that PR:

The original PR: #27791

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/Core (generators)
  • TauAnalysis/MCEmbeddingTools (simulation)

@SiewYan, @civanch, @mkirsano, @mdhildreth, @cmsbuild, @GurpreetSinghChahal, @Saptaparna, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Feb 14, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7fedb/22406/summary.html
COMMIT: 3271db1
CMSSW: CMSSW_10_6_X_2022-02-13-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36955/22406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Feb 15, 2022

+1

@civanch
Copy link
Contributor

civanch commented Feb 16, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 16, 2022

+1

@cmsbuild cmsbuild merged commit e28e536 into cms-sw:CMSSW_10_6_X Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants